mindphlux wrote:

Attached patch modifies the game to behave as desired in the bug report. Player gets an error message when attempting to build an airport, ship dock or depot, road depot when there are no vehicles available for this building type. Patch includes english and german error messages.

Patch does not include prevention of building a bus or truck stop.

Attachments

• patch-669.patch (5.82 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/669#comment1104

Celestar wrote:

a few comments concerning that diff:

1. The check MUST be inside the DoCommand call, because otherwise a modified client will crash a server.
2. the loop should be done using "FOR_ALL_ENGINES".

A question is whether this is the way to go, or just to prevent opening the toolbar in the first place.

This comment was imported from FlySpray: https://bugs.openttd.org/task/669#comment1105

mindphlux wrote:

Attached is a new diff:

- loop uses FOR_ALL_ENGINES now
- check is done when clicking the toolbar icons for road/ship/air, if it fails, the toolbar won't be opened

Attachments

• patch-669-rev2.patch (1.61 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/669#comment1106

DaleStan wrote:

road/ship/air
Why is rail not mentioned here? And shouldn't heilports have a different checke than airports?

+STR_CANT_BUILD_AIRPORT_YET :{WHITE}No aircraft available to build an airport for!
<...>

Please don't end sentences with a preposition. Is there some reason you didn't just put a period after "available"?
Alternatively, and more in line with TTD's original messages: "Can't build airport here ...n... No aircraft available."

This comment was imported from FlySpray: https://bugs.openttd.org/task/669#comment1108

mindphlux wrote:

Rail is not mentioned because that already had the proper check in place. You cannot even open the railroad menu if you have no engines available (at least thats what I found out on the current revision).

Also, my first patch is already replaced by a new version, attached to my second post. There is no error message anymore.

This comment was imported from FlySpray: https://bugs.openttd.org/task/669#comment1109

Chris wrote:

I didn't know there is a patch already so I started a new one from scratch where I did a few things differently.

- The vehicle lists of not allowed vehicles are not shown (error)
- The build tools (train, ship, air) are not shown when no vehicles are allowed (error)
- The road build tools are shown even when road vehicles can't be built but the buttons for depots, bus and truck stations are disabled

See related forum post: http://www.tt-forums.net/viewtopic.php?t=31731

Attachments

• buildpatch_v01_created_from_9756.patch (5.71 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/669#comment1184

Rubidium closed the ticket.

Reason for closing: Fixed

In r10353, though it is optional.

This comment was imported from FlySpray: https://bugs.openttd.org/task/669