Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "RUB" as new currency #6678

Closed
DorpsGek opened this issue Feb 12, 2018 · 7 comments
Closed

Add "RUB" as new currency #6678

DorpsGek opened this issue Feb 12, 2018 · 7 comments
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) good first issue Good for newcomers

Comments

@DorpsGek
Copy link
Member

PaulC opened the ticket and wrote:

Currency used by Russia since 1998 is the Russian Ruble (RUB), not (RUR). Current real-world exchange rate is approx. £1 x 80 which is higher than the OTTD rate.

Also (and this mainly affects the UK English translation), currencies are mostly named in the singular which means these two are incorrect:

* Russian Rubles -- should be Russian Ruble
* Estonian Krooni -- should be Estonian Kroon

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6678
@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 4, 2018

andythenorth wrote:

There are 3 issues here. For 2 of them:
• Exchange rates won't be maintained :)
• Translations should be fixable via https://translator.openttd.org/

I've left the issue open as RUB has replaced RUR in real life. This could be changed in the translation, but also the string names should then change. But that would need a migration of all translated strings, or the existing translations would be lost. I can't see that getting fixed, but I can't really just close this either.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6678#comment14855

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 4, 2018

PaulC wrote:

Exchange rates don't have to be actively maintained but they also don't need to be set in stone, no good reason why they couldn't or shouldn't be changed when it makes sense to do so.

For RUR/RUB, would it really be necessary to change the string name? While the discrepancy may not be ideal it doesn't really matter what name you give to the strings.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6678#comment14857

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 5, 2018

andythenorth wrote:

Suggestion: add a new currency for RUB. RUB wasn't just a change of ISO code, RUB and RUR are two different currencies.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6678#comment14862

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
@TrueBrain TrueBrain added good first issue Good for newcomers enhancement Issue would be a good enhancement; we accept Pull Requests! and removed enhancement under review labels Apr 7, 2018
@TrueBrain TrueBrain changed the title Currency errors: Russian Ruble, Estonian Kroon Add "RUB" as new currency Apr 11, 2018
@frosch123 frosch123 removed the Core label Apr 14, 2018
@ldpl
Copy link
Contributor

ldpl commented Apr 15, 2018

One Ruble is enough imo :)
Also people get used to exchange rates and prices so constantly changing them would be annoying. Especially on goal servers where goal is set in one currency. But having some rates changed once in a while for a good reason is ok I guess.

@nielsmh
Copy link
Contributor

nielsmh commented Jul 30, 2018

Wouldn't a better solution actually be to generalize the "Euro system", so instead of currencies having a simple "gets replaced with Euro in year 2000" flag, they have a "replaced by other currency" and "replaced year" field, so DEM becomes EUR in 2000, RUR becomes RUB in 1998, and EEK becomes EUR in 2011?

@TrueBrain
Copy link
Member

As a new ticket, sure :) Would be even better if it could be done with a NewGRF or something, as constant code changes for this feels silly ;P

But first just adding the currency seems to easiest step forward; after that we can overengineer it :D

@TrueBrain
Copy link
Member

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants