Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bus stations can be demolished when not in the demolish mode. #6659

Closed
DorpsGek opened this issue Jan 7, 2018 · 1 comment
Closed

Bus stations can be demolished when not in the demolish mode. #6659

DorpsGek opened this issue Jan 7, 2018 · 1 comment
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jan 7, 2018

james1101 opened the ticket and wrote:

Using Win 7 Ultimate

To Reproduce:

  1. Build a bus stop.
  2. Select the bus stop building icon and then select the demolish icon.
  3. Click and hold on the bus stop you just built.
  4. Press R to go out of the demolishing mode.
  5. Release the mouse button.
  6. The bus stop is still demolished, even though when you released the mouse it was not in the demolish mode.
    To clarify the steps, I've attached a visual version of them.

Works with: Bus and tram stops (both passenger and freight)
Does not work with: Train stations, railway tracks and roads

Attachments

Reported version: 1.7.2-RC1
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/6659
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
@andythenorth
Copy link
Contributor

Probably mouse-up vs. mouse-down event handling, but I haven't checked src.

@frosch123 frosch123 removed the Core label Apr 14, 2018
alex6m59 pushed a commit to alex6m59/OpenTTD that referenced this issue Jun 4, 2018
… mode

For Bus and Road stations only, if you are in demolish mode and click on the station
without releasing the button. Then you cancel demolish mode with R key.
Finally you release the mouse button. The station was demolished, instead of being built.

The demolish mode was not checked when mouse up event occured.
alex6m59 added a commit to alex6m59/OpenTTD that referenced this issue Jun 4, 2018
… mode

For Bus and Road stations only, if you are in demolish mode and click on the station
without releasing the button. Then you cancel demolish mode with R key.
Finally you release the mouse button. The station was demolished, instead of being built.

The demolish mode was not checked when mouse up event occured.
@PeterN PeterN closed this as completed in 25dbc65 Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

4 participants