Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buying exclusive transport rights prevents oil rigs from using their own dock/helipad #6657

Closed
DorpsGek opened this issue Jan 7, 2018 · 5 comments
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) good first issue Good for newcomers patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay stale Stale issues

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jan 7, 2018

mctom opened the ticket and wrote:

Hi, I guess the summary is pretty much straightforward.. I can't tell whether this behavior is intended. I have built a railway station near the oil rig, bought exclusive rights in its parent town, and all oil and passengers were dumped into my train station. Further investigation reveals that any oil rig will simply stop using its own dock because it's treated as my competition.

I don't include any attachments since it's quite easy to reproduce.

I'm using OpenTTD v. 1.4.4, but I couldn't find similar reports in this task list. Hope it helps!

Reported version: other
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6657
@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 2, 2018

Samu wrote:

I like to believe it is a bug. My proposed "fix".

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6657#comment14840

@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 2, 2018

mctom wrote:

Thanks a lot for looking into this!


This comment was imported from FlySpray: https://bugs.openttd.org/task/6657#comment14841

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
@TrueBrain TrueBrain added good first issue Good for newcomers patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay bug Something isn't working and removed bug from FlySpray labels Apr 12, 2018
@frosch123 frosch123 removed the Core label Apr 14, 2018
@nielsmh
Copy link
Contributor

nielsmh commented Jun 9, 2018

I don't think the attached patch is complete. If company A has exclusive rights with the town, then only company A should be allowed to service the oil rig station, but the station should keep accepting and receiving cargo. Any company B vehicles stopping at the station should be unable to load or unload cargo, to keep the exclusivity for company A.

@andythenorth andythenorth added the stale Stale issues label Jan 5, 2019
@andythenorth
Copy link
Contributor

andythenorth commented Jan 5, 2019

Thanks for this. There's been no activity on this for some time, and as it stands, it doesn't look likely that it will go any further. Since OpenTTD moved to GitHub, we use pull requests rather than patches, as they are a much more productive workflow.

I'm planning to close this soon (in 7 days), as we try to keep the issue count low for OpenTTD, it helps us focus on things that are important and fun.

If you would like to continue with this patch, the best way would be to move the patch to your own GitHub fork, update it for the current OpenTTD master, and then create a pull request. For more information, please see our CONTRIBUTING.md.

We are also happy to discuss directly on the issue, or in #openttd irc, including help to get this into a pull request. Thanks for your contribution!

@andythenorth
Copy link
Contributor

Closing as stale. The behaviour is intended IMO, as oil rig stations are shared, and buying exclusive transport rights excludes any station available to competitors. But eh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) good first issue Good for newcomers patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay stale Stale issues
Projects
None yet
Development

No branches or pull requests

6 participants
@nielsmh @TrueBrain @andythenorth @DorpsGek @frosch123 and others