Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less towns than set in menu #6640

Closed
DorpsGek opened this issue Nov 20, 2017 · 4 comments
Closed

Less towns than set in menu #6640

DorpsGek opened this issue Nov 20, 2017 · 4 comments
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) good first issue Good for newcomers

Comments

@DorpsGek
Copy link
Member

PaulC opened the ticket and wrote:

Just a thought based on this forum topic: https://www.tt-forums.net/viewtopic.php?f=31&t=77182

Setting custom no. of towns to 5000 (or whatever) won't necessarily give you a map with that number of towns, for a number of reasons that may not be obvious to the user. Perhaps it would be an idea to display a message at the start of the game if this is the case, e.g. "Cannot generate requested number of towns; not enough room on map" or "not enough available town names"?

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6640
@DorpsGek
Copy link
Member Author

james1101 wrote:

Or the message could be "Could not generate requested number of towns; only enough room for XXXX towns" or "not enough town names (XXXX available)", with error code string "ERR_CANNOT_GENERATE_REQUESTED_TOWNS".


This comment was imported from FlySpray: https://bugs.openttd.org/task/6640#comment14806

@DorpsGek
Copy link
Member Author

hackalittlebit wrote:

Just a sugestion.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6640#comment14834

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
@TrueBrain TrueBrain added good first issue Good for newcomers patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay enhancement Issue would be a good enhancement; we accept Pull Requests! and removed enhancement from FlySpray labels Apr 12, 2018
@frosch123 frosch123 removed the Core label Apr 14, 2018
@andythenorth
Copy link
Contributor

Thanks for this. There's been no activity on this for some time, and as it stands, it doesn't look likely that it will go any further. Since OpenTTD moved to GitHub, we use pull requests rather than patches, as they are a much more productive workflow.

I'm planning to close this soon (in 7 days), as we try to keep the issue count low for OpenTTD, it helps us focus on things that are important and fun.

If you would like to continue with this patch, the best way would be to move the patch to your own GitHub fork, update it for the current OpenTTD master, and then create a pull request. For more information, please see our CONTRIBUTING.md.

We are also happy to discuss directly on the issue, or in #openttd irc, including help to get this into a pull request. Thanks for your contribution!

@LordAro LordAro removed the patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay label Jan 13, 2019
@LordAro
Copy link
Member

LordAro commented Jan 13, 2019

Closed in favour of #7059

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants