Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluidsynth music driver #6611

Closed
DorpsGek opened this issue Aug 18, 2017 · 1 comment
Closed

Fluidsynth music driver #6611

DorpsGek opened this issue Aug 18, 2017 · 1 comment
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) OS: Linux Issues specific to Linux builds patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

LordAro opened the ticket and wrote:

https://www.tt-forums.net/viewtopic.php?f=33&t=57037 by jmak

Last version attached. Will need updating

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6611
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
@frosch123 frosch123 removed the Core label Apr 14, 2018
@nielsmh nielsmh added OS: Linux Issues specific to Linux builds music enhancement Issue would be a good enhancement; we accept Pull Requests! labels Aug 1, 2018
@planetmaker
Copy link
Contributor

The patch's comment style is not entirely consistent in src/music/fluidsynth.cpp. It uses // in 3 places where it should use /* ... */. Otherwise... it probably could be changed to a pull-request, if it works; but it might need adjustment in the build infrastructure, or our tests will pass and builds ship w/o it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) OS: Linux Issues specific to Linux builds patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

4 participants