Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towns: allow towns to build houses on road turns #6610

Closed
DorpsGek opened this issue Aug 18, 2017 · 4 comments
Closed

Towns: allow towns to build houses on road turns #6610

DorpsGek opened this issue Aug 18, 2017 · 4 comments
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) good first issue Good for newcomers patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

dp opened the ticket and wrote:

Right towns can't build houses on corner tiles of road turns (see screenshot). So while it's possible for house to appear there via replacement it's still highly unlikely, so usually those spots stay as an bare land eyesore.

Also even though it's possible to make town fill such spot by bringing a road close from other side it doesn't fit any regular (let alone effective) layout since town growth mechanics kind of encourage layouts with 2-tile space between roads.

And fundamentally it would be nice for any road (not just straight one) to have 2 new house spots for each tile it goes from town center. So it will encourage players to do more turns on roads without loosing efficiency (and actually even gaining some) e.g. https://citymania.org/tools/townsim/layouts/10 or mb some tree-like ones. Because right now square spiral-like layout ( https://citymania.org/tools/townsim/layouts/2 ) is pretty much the best one for effecient growth. Btw you can enable this house on turn mechanics in town emulator (in more options) to see how it will work.

I'm attaching patch that introduces such behavior. Note that it also maintains equal probability for a possible house spots to be chosen.

Attachments

Reported version: 1.7.1
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6610
@DorpsGek
Copy link
Member Author

dp wrote:

Damn, thought of a possible bug right when I pressed the button. I'll check it tomorrow.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6610#comment14544

@DorpsGek
Copy link
Member Author

andythenorth wrote:

I rely on those gaps for placing distant-join station tiles to increase coverage.

But most things we want to change will have someone who likes the existing behaviour, eh?

I agree, they're ugly, and would be better gone :)


This comment was imported from FlySpray: https://bugs.openttd.org/task/6610#comment14545

@DorpsGek
Copy link
Member Author

dp wrote:

Ok, it wasn't a bug after all. Only found redundant allow_house=true assignment, so removing that.

I was worried that circumventing layout checks with target_dir = DIAGDIR_END may cause some issues but it wasn't called for road turns before. And all it does is checking whether it needs to build a road or extra house in that direction and neither of those applies to corner tiles. Also it checks layout later on so it will never build house in a spot reserved for layout anyway.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6610#comment14546

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 3, 2017

andythenorth wrote:

Applied to r27911. Houses build in corners, as expected.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6610#comment14753

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
@TrueBrain TrueBrain added patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay enhancement Issue would be a good enhancement; we accept Pull Requests! good first issue Good for newcomers and removed enhancement from FlySpray labels Apr 11, 2018
@frosch123 frosch123 removed the Core label Apr 14, 2018
ldpl added a commit to ldpl/OpenTTD that referenced this issue Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) good first issue Good for newcomers patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

3 participants