Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console: generation seed that you set manually is overwritten with a random value in some cases #6604

Closed
DorpsGek opened this issue Aug 13, 2017 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

james1101 opened the ticket and wrote:

This bug annoys people who want to do a newmap using a specific seed.

Case A: Set seed from console then newmap from ingame

  1. Set the seed via console (set generation_seed N)
  2. Start newmap from ingame.
    -> Seed is overwritten with random value
    Case B: Set seed from console then newmap from console, all while in the intro
  3. Abandon any game you may have running
  4. Set the seed in the console
  5. Start new map from console
    -> Seed is overwritten with random value
    Case C: Same thing as above but while the map settings window is open
  6. Abandon any game you may have running
  7. Open the map settings window by clicking on the New Game button.
  8. Set the seed in the console
  9. Start new map from console
    -> Seed is overwritten with random value
    Case D: While in intro, set seed in console then click Generate in Map settings
  10. Abandon any game you may have running
  11. Open the map settings window by clicking on the New Game button.
  12. Set the seed in the console
  13. Start new map via the map settings window
    -> Seed is not overwritten with random value
    Case E: Same thing as above but Control-click on new game button instead
  14. Abandon any game you may have running
  15. Set the seed in the console
  16. Start new map via ctrl-clicking on the new game button
    -> Seed is overwritten with random value

Out of the five cases there is only one way to set the seed before starting the game and not have it overwritten with a random value, and that is case / method D. I would like all five cases to not overwrite the seed with a random value each.

OpenTTD Version 1.7.1 running on Win 7 Ultimate.

Reported version: 1.7.1
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/6604
@DorpsGek
Copy link
Member Author

Wolf01 wrote:

I found why it does this and I'm working on it.
Also I'll discuss with devs about the reintroduction of the seed box removed 3 years ago.

EDIT: attached patch, needs to be reviewed

Had a talk with devs, the map seed must be set with "newgame [seed]" and not with "set generation_seed [seed]", so even if my incomplete patch solved the "set generation_seed" problem, it's not the right way to do it, by design.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6604#comment14644

@DorpsGek
Copy link
Member Author

Wolf01 closed the ticket.

Reason for closing: Won't fix

Flyspray clean up: not obvious what else should be done with this, so closing now. If this offends, discuss with Wolf01 in irc. Thanks for the report :)


This comment was imported from FlySpray: https://bugs.openttd.org/task/6604

@DorpsGek
Copy link
Member Author

frosch wrote:

To clarify:
* The settings commands are easier to understand when inside a game. The intro GUI stretches the terms.
* The "setting" command changes settings of the current game. "setting_newgame" does the same for new games. In the intro GUI they are the same.
* The "generation_seed" setting is supposed to be the seed of the current game. Changing it inside a game is pointless.
* The "newgame" command starts a new game with a new seed. In particular executing it multiple times in succession within a game always gives you a new map.
* The "restart" command starts a new game with the same settings and same seed as the current one.

This task has two misconceptions:
* You are not supposed to change the "generation_seed" setting since it refers to the current game.
* You try to make "newgame" and "restart" the same thing, which essentially completely breaks the purpose of "newgame". You run "newgame" when you want to keep the settings but did not like the result of the seed.

I did not try whether "restart" works in the intro GUI or what it does.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6604#comment14648

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant