Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the behavior of Entry Signal on unavailable turns #6595

Closed
DorpsGek opened this issue Jul 30, 2017 · 6 comments
Closed

Improve the behavior of Entry Signal on unavailable turns #6595

DorpsGek opened this issue Jul 30, 2017 · 6 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

neschur opened the ticket and wrote:

Signal 1 is green, because signal 3 is green
But Train A can't get to signal 3
And Signal 1 should be red

In some cases(complex stations or this simple example) this behavior defect limits opportunities road builds

It is very important for me, and I tried to rewrite signals algorithm, I partially investigated source code, but implementation this feature turned out for me too difficult. If nobody don't want to work on this feature, maybe anyone can help me for implementation this feature?

Attachments

Reported version: 1.7.1
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6595
@DorpsGek
Copy link
Member Author

neschur wrote:

I found function in signal.cpp: ExploreSegment
I thought that I can check nearest tiles and set on unavailable tile "red" signal or ignore this tile, but In this way I can't to ignore any next tiles.
As I understand, it function completely ignore order of tile, and it is required refactoring tile storage and order of iterations, Am I right?
Or It can be implemented by any other way?


This comment was imported from FlySpray: https://bugs.openttd.org/task/6595#comment14479

@DorpsGek
Copy link
Member Author

adf88 wrote:

It's intended behavior, these are "block" signals by design. If I understand correctly, you would like to add some test and check whether the signal can be actually reached by the train using current tracks right? Use path signals if you want this kind of functionality.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6595#comment14480

@DorpsGek
Copy link
Member Author

neschur wrote:

Thank you for answer
Yes, path signals can be used in this case, but I think not sense show green light on entry signal when train can't arrive to next green signal
I my opinion Entry/Exit signal look better in some cases


This comment was imported from FlySpray: https://bugs.openttd.org/task/6595#comment14482

@DorpsGek
Copy link
Member Author

adf88 wrote:

"I think not sense show green" - there is sense. That's the basic property of these signal which is used in many different setups e.g. in a priority merge:

https://wiki.openttd.org/Priority_Merge

Although that train on the right can't reach that exit combo signal, this exit combo signal influences that entry signal in front of the train anyway.

These are "block" signals, they work based on whole rail track "blocks" rather then single paths. And it's useful in many ceases. In other cases, path signals are useful.

I think we don't need another signals which are something between these two types.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6595#comment14483

@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 3, 2017

neschur wrote:

Thank you, I played in game and completely understand how path signal should be used


This comment was imported from FlySpray: https://bugs.openttd.org/task/6595#comment14489

@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 5, 2017

Alberth closed the ticket.

Reason for closing: Requested by user


This comment was imported from FlySpray: https://bugs.openttd.org/task/6595

@DorpsGek DorpsGek closed this as completed Aug 5, 2017
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant