Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orders: last order line says "End of orders" but delete button says "Stop sharing". #6593

Closed
DorpsGek opened this issue Jul 26, 2017 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

james1101 opened the ticket and wrote:

To Reproduce:

  1. Build two vehicles and some stations.
  2. In the first vehicle orders window, give some orders and share them with the second vehicle.
  3. Select the "End of (shared) orders" line at the bottom of the order list.
  4. Press the "Stop sharing" button on one of the order windows.

Expected: On the other order window, the last line changes to "End of Orders", but the "Stop sharing" button remains the same, and that button does nothing, even if I ctrl+click.
Actual: The "Stop sharing" button on the other order window should have changed to a regular "Delete" button.

Attachments

Reported version: 1.7.1
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6593
@DorpsGek
Copy link
Member Author

adf88 wrote:

Confirmed and fixed (perform full "invalidatedata" on the window rather then just "setdirty"):

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6593#comment14478

@DorpsGek
Copy link
Member Author

andythenorth wrote:

Confirmed issue in 1.7.1. Tested patch on r27896, confirmed fixed.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6593#comment14615

@DorpsGek
Copy link
Member Author

adf88 closed the ticket.

Reason for closing: Implemented

in r27904


This comment was imported from FlySpray: https://bugs.openttd.org/task/6593

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant