New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrolling down/right out of map on a 255 high flat map bounces viewport back to edge of map #6583
Comments
adf88 wrote:
Attachments
This comment was imported from FlySpray: https://bugs.openttd.org/task/6583#comment14465 |
adf88 wrote:
Attachments
This comment was imported from FlySpray: https://bugs.openttd.org/task/6583#comment14466 |
adf88 wrote:
This comment was imported from FlySpray: https://bugs.openttd.org/task/6583#comment14469 |
adf88 wrote:
Attachments
This comment was imported from FlySpray: https://bugs.openttd.org/task/6583#comment14472 |
Seems like this has patches for both?
|
Thanks for this. There's been no activity on this for some time, and as it stands, it doesn't look likely that it will go any further. Since OpenTTD moved to GitHub, we use pull requests rather than patches, as they are a much more productive workflow. I'm planning to close this soon (in 7 days), as we try to keep the issue count low for OpenTTD, it helps us focus on things that are important and fun. If you would like to continue with this patch, the best way would be to move the patch to your own GitHub fork, update it for the current OpenTTD master, and then create a pull request. For more information, please see our CONTRIBUTING.md. We are also happy to discuss directly on the issue, or in #openttd irc, including help to get this into a pull request. Thanks for your contribution! |
…ZOutsideMap functions (Patch by adf88, OpenTTD#6583)
…oordinates to underlying tile coordinates (Patch by adf88, OpenTTD#6583)
…ap (Patch by adf88, OpenTTD#6583)
…wn as fast as possible" tile height model (Patch by adf88, OpenTTD#6583)
Patches moved to #7061 |
…ZOutsideMap functions (Patch by adf88, #6583)
…oordinates to underlying tile coordinates (Patch by adf88, #6583)
…wn as fast as possible" tile height model (Patch by adf88, #6583)
…k ViewportAddLandscape so it no more relies on "go down as fast as possible" tile height model (Patch by adf88, OpenTTD#6583)" This reverts commit 479f13f.
…ZOutsideMap functions (Patch by adf88, OpenTTD#6583)
…oordinates to underlying tile coordinates (Patch by adf88, OpenTTD#6583)
…ap (Patch by adf88, OpenTTD#6583)
…wn as fast as possible" tile height model (Patch by adf88, OpenTTD#6583)
…k ViewportAddLandscape so it no more relies on "go down as fast as possible" tile height model (Patch by adf88, OpenTTD#6583)" This reverts commit 479f13f.
I think the code is fine; noting that the second argument to ExecuteTerraforming() is false, the code is really very similar to that created by commit 05da5a1 "Codechange: Simplify marking tiles dirty when terraforming (Patch by adf88, OpenTTD#6583)".
…ZOutsideMap functions (Patch by adf88, OpenTTD#6583)
…oordinates to underlying tile coordinates (Patch by adf88, OpenTTD#6583)
…ap (Patch by adf88, OpenTTD#6583)
…wn as fast as possible" tile height model (Patch by adf88, OpenTTD#6583)
…k ViewportAddLandscape so it no more relies on "go down as fast as possible" tile height model (Patch by adf88, OpenTTD#6583)" This reverts commit 479f13f.
james1101 opened the ticket and wrote:
Attachments
Reported version: 1.7.1
Operating system: Windows
This issue was imported from FlySpray: https://bugs.openttd.org/task/6583
The text was updated successfully, but these errors were encountered: