Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash upon executing too many commands at once while outputting to external console #6576

Closed
DorpsGek opened this issue Jun 22, 2017 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

james1101 opened the ticket and wrote:

  1. Start OpenTTD.

  2. Run console command: 'exec openttd.cfg' and/or some other file with lots of lines of commands stored.
    Check to make sure it works.

  3. Run console commands in order: 'debug_level console=99', then 'exec openttd.cfg'.
    BUG: Game crashes upon the 'exec openttd.cfg' being run.

Possible reason: Game is outputting too much text to the external console (the one included in the OS), which causes it to crash.

Possible solution: Output only so many lines at most to the external console per frame or game tick.

Attachments

Reported version: 1.7.1
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/6576
@DorpsGek
Copy link
Member Author

frosch wrote:

Information from crash.dmp:
0012e00c 006ae7d7 0012e02c 00ed7dfc 00000000 openttd!_output_l+0x97e [f:\dd\vctools\crt_bld\self_x86\crt\src\output.c @ 1643]
0012e04c 006ae818 0012e0b0 00000400 00ed7dfc openttd!_vsnprintf_l+0x83 [f:\dd\vctools\crt_bld\self_x86\crt\src\vsprintf.c @ 138]
0012e068 0044dc3a 0012e0b0 00000400 00ed7dfc openttd!_vsnprintf+0x18 [f:\dd\vctools\crt_bld\self_x86\crt\src\vsprintf.c @ 190]
0012e084 0044d787 0012e0b0 00000400 00ed7dfc openttd!vsnprintf+0x29 [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\string.cpp @ 365]
0012e09c 0040c9e8 0012e0b0 00ed7dfc 0012e4c0 openttd!vseprintf+0x22 [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\string.cpp @ 54]
0012e4b0 004092e4 00ed7c40 00ed7dfc 00000014 openttd!debug+0x1f [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\debug.cpp @ 166]
0012ed28 0040a313 0000000d 04470048 00000000 openttd!IConsoleCmdExec+0x163 [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\console.cpp @ 477]
0012f140 0040934e 044fa1a0 0000000d 63657865 openttd!ConExec+0xb8 [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\console_cmds.cpp @ 959]
0012f9a8 004783c7 0000000d 00468ff6 0000000d openttd!IConsoleCmdExec+0x1cd [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\console.cpp @ 491]
0012f9b0 00468ff6 0000000d 0000000d 0000000d openttd!IConsoleWindow::OnKeyPress+0x122 [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\console_gui.cpp @ 314]
0012f9c8 005daece 0000000d 0000000d 00000102 openttd!HandleKeypress+0x42 [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\window.cpp @ 2605]
0012f9dc 005db4ec 0000000d 0012fad4 00000102 openttd!HandleCharMsg+0x94 [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\video\win32_v.cpp @ 490]
0012fa54 0012fa84 75d686ef 001a036c 00000102 openttd!WndProcGdi+0x33a [c:\bamboo-agent-home\xml-data\build-dir\ottd-rls-w32bit\src\video\win32_v.cpp @ 820]


This comment was imported from FlySpray: https://bugs.openttd.org/task/6576#comment14449

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Fixed

in r27883


This comment was imported from FlySpray: https://bugs.openttd.org/task/6576

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant