Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Visual Studio 2017 solution and projects #6570

Closed
DorpsGek opened this issue May 28, 2017 · 5 comments
Closed

Add Visual Studio 2017 solution and projects #6570

DorpsGek opened this issue May 28, 2017 · 5 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

harre opened the ticket and wrote:

Use this commit: hartmark@68534cc

Here's the patch: https://github.com/hartmark/OpenTTD/commit/68534ccd39bb566aac8a91ba16b93ef9fbbc82ce.patch

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6570
@DorpsGek
Copy link
Member Author

frosch wrote:

Apparently the only difference in the project files from MSVC2015 to MSVC2017 are:
* "ToolsVersion": "14.0" -> "15.0"
* "PlatformToolset": "v140" -> "v141"
* Addition of "WindowsTargetPlatformVersion" with value "10.0.15063.0", which looks dubious to me.

Are the new project files even needed? Don't the MSVC2015 files just work?

Either way:
* I think the project files are supposed to be named "150", matching the internal version number of MSVC.
* The generation scripts "generate" and "generate.vbs" together with all the ".in" and ".filters" files need to be adjusted.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6570#comment14451

@DorpsGek
Copy link
Member Author

harre wrote:

Yeah, it seems that I'm able to get it working with just using the openttd_vs140.sln

I were just missing the proper include folders and import folders.

We can close this bug.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6570#comment14452

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Won't implement


This comment was imported from FlySpray: https://bugs.openttd.org/task/6570

@DorpsGek
Copy link
Member Author

TrueBrain wrote:

With a recent patch from LordAro adding FALLTHROUGH to OpenTTD, VS2017 is yelling it needs to be in /std:c++latest. Possibly it is a good moment to introduce project files for VS2017, as then it can be changed on Project level (instead of individual).


This comment was imported from FlySpray: https://bugs.openttd.org/task/6570#comment14774

@DorpsGek
Copy link
Member Author

frosch wrote:

I added MSVC2017 to "generate" and "generate.vbs".
The project files differ from MSVC2015 in
* ToolsVersion 14.0 -> 15.0
* PlatformToolset v140 -> v141
* AdditionalOptions now contains /std:c++latest


This comment was imported from FlySpray: https://bugs.openttd.org/task/6570#comment14775

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant