Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSX] "Scrollwheel: Scroll map" causes window focus to follow mouse on macOS 10.12.4 (Sierra) #6558

Closed
DorpsGek opened this issue Apr 15, 2017 · 2 comments · Fixed by #6793
Closed
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) OS: MacOS This issue is related to a Mac OS problem

Comments

@DorpsGek
Copy link
Member

andythenorth opened the ticket and wrote:

On macOS (OS X) 10.12.4 (Sierra) setting "Function of scrollwheel" to "Scroll map" causes the game window focus to follow the mouse cursor, intermittently.

Present in multiple OpenTTD versions, self-compiled (around r27848), and from compile farm (1.6.1). Cannot reproduce with 1.3.0 (doesn't mean it's not there, but couldn't trigger it).

Using a trackpad with two-finger scroll, not a scrollwheel, but eh, should be same result to the OS.
I have tried independently toggling all the OS-level trackpad and scroll settings, including the accessibility settings, but nothing I tried made a difference.
No access right now to older OS X versions to test, but I can do that at another time.

The effect is intermittent, but relatively easy to reproduce.
- can be triggered always on the newgrf window at game start screen, by opening newgrf settings window, then a parameters window (which will initially open behind the newgrf settings window, incorrectly)
- can be triggered in game by e.g. opening a depot, then 'build vehicles'. Focus-follows-mouse tends to stop periodically, for undetermined reasons, but can be reliably re-started by using scroll on a game window such as depot or vehicles.

I have not been able to reproduce the issue with "Function of scrollwheel: Zoom map" or "Function of scrollwheel: Off".

Reported version: trunk
Operating system: Mac OS X


This issue was imported from FlySpray: https://bugs.openttd.org/task/6558
@DorpsGek
Copy link
Member Author

andythenorth wrote:

Hard to understand wtf I'm talking about?

Video here http://dev.openttdcoop.org/attachments/download/8417/focus-follows-mouse.mov

Shows varying behaviour of newgrf window depending on scroll setting (I am not clicking mouse to gain window focus in the first example, just moving it). Same behaviour happens for windows during gameplay.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6558#comment14433

@DorpsGek
Copy link
Member Author

andythenorth wrote:


This comment was imported from FlySpray: https://bugs.openttd.org/task/6558#comment14434

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
@TrueBrain TrueBrain added OS: MacOS This issue is related to a Mac OS problem bug Something isn't working and removed bug from FlySpray labels Apr 10, 2018
@frosch123 frosch123 removed the Core label Apr 14, 2018
alexanderweiss added a commit to alexanderweiss/OpenTTD that referenced this issue Apr 28, 2018
…to prevent unintended window focus changes
alexanderweiss added a commit to alexanderweiss/OpenTTD that referenced this issue Apr 28, 2018
…to prevent unintended window focus changes
alexanderweiss added a commit to alexanderweiss/OpenTTD that referenced this issue Apr 30, 2018
…to prevent unintended window focus changes
alexanderweiss added a commit to alexanderweiss/OpenTTD that referenced this issue May 22, 2018
…to prevent unintended window focus changes
alexanderweiss added a commit to alexanderweiss/OpenTTD that referenced this issue May 28, 2018
…to prevent unintended window focus changes
PeterN pushed a commit that referenced this issue May 29, 2018
* Codechange: Check for scrollwheel_scrolling first when scrolling viewport instead of first setting normal values and then overwriting them.

* Fix #6558: [OSX] Reset 2D scrolling values when not scrolling to prevent unintended window focus changes

* Change: [OSX] Include initial scrolling movement when using 2D scrolling to make it more responsive

* Fix: [OSX] 2D scrolling not working when setting viewport scroll behaviour to use left mouse button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) OS: MacOS This issue is related to a Mac OS problem
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants