Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buoys can prevent oil rig spawns #6548

Closed
DorpsGek opened this issue Mar 25, 2017 · 7 comments
Closed

Buoys can prevent oil rig spawns #6548

DorpsGek opened this issue Mar 25, 2017 · 7 comments
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) needs triage This issue needs further investigation before it becomes actionable stale Stale issues

Comments

@DorpsGek
Copy link
Member

Samu opened the ticket and wrote:

When an oil rig is spawning, the special water check require that the tile is of type water. Ship Depots and Locks are tiles of type water and won't prevent oil rig from spawning. Buoys, however, are of tile type station, and are preventing oil rigs from spawning.

This patch should allow it to spawn when checking for water nearby on buoys as well.

Attachments

Reported version: 1.7.0-RC1
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6548
@DorpsGek
Copy link
Member Author

Samu wrote:

My bad, made a bool mistake, this patch should do what I was intending.

EDIT: now with parentesis. Use v3.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6548#comment14402

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 1, 2017

peter1138 wrote:

Arguably the check should be extended the other way so that depots and locks are excluded?


This comment was imported from FlySpray: https://bugs.openttd.org/task/6548#comment14405

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 3, 2017

peter1138 wrote:

Ok, so now depots and locks aren't considered clear... does it make sense that buoys should be? I think probably not.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6548#comment14415

@DorpsGek
Copy link
Member Author

andythenorth wrote:

If we're changing this, I would consider depots and locks not clear. Also buoys not clear.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6548#comment14624

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
@TrueBrain
Copy link
Member

I am a bit lost in the comments; I cannot figure out if this is already fixed or not. Either way, I agree: it should not work on depots, locks, buoys, or anything that is in the way :) If this is the case, close ticket. IF not, bug to fix :)

@TrueBrain TrueBrain added needs triage This issue needs further investigation before it becomes actionable bug Something isn't working and removed bug from FlySpray labels Apr 13, 2018
@frosch123 frosch123 removed the Core label Apr 14, 2018
@andythenorth andythenorth added the stale Stale issues label Jan 5, 2019
@andythenorth
Copy link
Contributor

Thanks for this. There's been no activity on this for some time, and as it stands, it doesn't look likely that it will go any further. I'm closing it as we try to keep the issue count low for OpenTTD, it helps us focus on things that are important and fun. Feel free to discuss in irc or request re-opening if you disagree. Thanks for contributing!

@SamuXarick
Copy link
Contributor

      I am a bit lost in the comments; I cannot figure out if this is already fixed or not. Either way, I agree: it should not work on depots, locks, buoys, or anything that is in the way :) If this is the case, close ticket. IF not, bug to fix :)

It is already fixed, can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) needs triage This issue needs further investigation before it becomes actionable stale Stale issues
Projects
None yet
Development

No branches or pull requests

5 participants