FS#6525 - Rating bonus for default economy also

Attached to Project: OpenTTD
Opened by SirkoZ (SirkoZ) - Wednesday, 07 December 2016, 12:59 GMT
Type Patch
Category Core
Status New
Assigned To No-one
Operating System All
Severity Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


I suggest rating bonus for default economy also because I feel it needs it.
This task depends upon

Comment by adf88 (adf88) - Monday, 26 December 2016, 06:32 GMT
"bonus for default economy also" - what do you mean by that? What is your patch supposed to do?
Comment by SirkoZ (SirkoZ) - Monday, 26 December 2016, 19:03 GMT
Well same as with smooth economy - if over 80% is transported, industry is even more likely to increase production.
Adds to playability.
Comment by Alberth (Alberth) - Friday, 26 May 2017, 07:18 GMT
Not sure how much sense it makes to improve non-smooth economy, but I can see the point.
@adf88: Compare smooth case with non-smooth case (industry_cmd.cpp, lines 2536-ish versus 2573-ish).

I think the 'else' branch needs to be cleaned up though, an "if (only_decrease || ..)" and a "if (!only_decrease && ..)" inside doesn't make a lot of sense there. Your patch now adds a hack rather than a proper fix.
Comment by SirkoZ (SirkoZ) - Sunday, 28 May 2017, 09:54 GMT
You have to admit, Alberth, that non-smooth portion is well-condensed and therefore might look as hacked together, however you have much inside:

Line 2572 - first if temperate Oil Wells (or other industry with only_decrease behaviour) or 1 out of 3 (as it was in TTD - I've gone through the Marcin's exe) then

again Line 2574 - if !only_decrease because you don't want to increase only_decrease industry (same as in TTD exe) and of course the
chance16 portion that I extended without adding all kinds of extra code - it should be concise and to the point, don't you agree?

Regards S/Z