You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Imho, deleting an order should behave the same as keeping that order in the queue but deleting/ignoring the instruction of the order.
However, deleting an order (say the n-th order), which is target of a (conditional) jump, the jump points to the (n-1)-st order (and not the n-th).
example of orders:
before:
always jump to order 3
go to waypoint1
go to waypoint2
go to waypoint3
after deleting order 3:
always jump to order 2
go to waypoint1
go to waypoint3
expected:
always jump to order 3
go to waypoint1
go to waypoint3
The current behaviour is unintuitive, since "waypoint1" was not reached before the deletion, but afterwards it is. In case the "n-th" is the last order, the target of the jump should change to 1.
Sry for not attaching a patch, but frankly I didn't understand the logic of what happens when I delete an order.
These kind of problems sadly don't have one solution. Sometimes you want it to change to the 3rd, sometimes to the 2nd. Basically, there is no good solution when you remove the order that a conditional jump is pointing to.
For now the code changes it to the one before; in your case it makes more sense to jump to the one after. But I am sure others can find situations where that doesn't make sense.
So sorry, going to close this issue. But feel free to rebuttal!
deep42thought opened the ticket and wrote:
Reported version: trunk
Operating system: All
This issue was imported from FlySpray: https://bugs.openttd.org/task/6501
The text was updated successfully, but these errors were encountered: