Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save empty scripts when sending map to clients #6478

Closed
DorpsGek opened this issue Jun 13, 2016 · 2 comments
Closed

Save empty scripts when sending map to clients #6478

DorpsGek opened this issue Jun 13, 2016 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Samu opened the ticket and wrote:

Taken apart from my project here: https://www.tt-forums.net/viewtopic.php?f=33&t=74694

"f) While hosting a server, AIs or GS are not going to be requested to save their data when a client attempts to join. But should you manually save the game or perform autosaves, AIs or GS are still going to be requested to save their data. This permits scripts that usually take too long to save to be useable while running a server for as long as no autosaves or manual saves are done during the session."

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6478
@DorpsGek
Copy link
Member Author

Alberth wrote:

If a script takes too long to save its data, I would say it's broken. It's producing a save that can't be used for loading.

The script should save less data, don't attempt to save it at all (and have some other means to recover that information), or reduce the time required to save the data eg by doing pre-computations or so.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6478#comment14215

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

As per Alberth's comment, this isn't necessary and probably not wise. Flyspray clean up, so closing thanks. If this offends, discuss in irc, thanks.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant