Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stations: store sprite layout entry in station var68 #6477

Closed
DorpsGek opened this issue Jun 13, 2016 · 3 comments
Closed

Stations: store sprite layout entry in station var68 #6477

DorpsGek opened this issue Jun 13, 2016 · 3 comments
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

mb opened the ticket and wrote:

Proposal:

In "station info of nearby tiles (68)", bits 14 .. 31 are still "reserved for future use". It would be helpful to store the "entry from sprite layout" (prop09/1A) in this range, probably only using 8 bits 14 .. 21, so there´d be still 10 bits left for future use.

Reported version: Version?
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6477
@DorpsGek
Copy link
Member Author

frosch wrote:

See also:
https://www.tt-forums.net/viewtopic.php?t=40788


This comment was imported from FlySpray: https://bugs.openttd.org/task/6477#comment14210

@DorpsGek
Copy link
Member Author

mb wrote:

[...] when you use this variable in callback 0x14 and the other tile does the same and
queries the layout of the first tile, you will end up with a nice recursion

Hm, yes. Didn´t recall my proposal from 2008. At least this shows that there´s ongoing demand for. :D

Well, obviously such circular references makes no sense whatsoever, and would be avoided.
I mean, there are already a lot of other bear traps in grf-coding which might result in "unwanted game behaviour". And at least, this can´t be achieved by an unprepared user, only by a buggy newgrf.

?


This comment was imported from FlySpray: https://bugs.openttd.org/task/6477#comment14211

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) NewStations labels Apr 7, 2018
@andythenorth andythenorth added the component: NewGRF This issue is related to NewGRFs label Apr 13, 2018
@TrueBrain
Copy link
Member

Of course we can use any reversed bits for anything, but without a clear use case why we should use it as such (what does it add? what value does it bring? etc), I do not think anyone will pick this up in any foreseeable future. So I am sorry, but I am going to close this issue, to avoid having tickets linger till the end of times :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

3 participants