New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a 32bpp SSE2 palette animator. #6469
Comments
andythenorth wrote:
This comment was imported from FlySpray: https://bugs.openttd.org/task/6469#comment14718 |
andythenorth wrote:
This comment was imported from FlySpray: https://bugs.openttd.org/task/6469#comment14747 |
LordAro wrote:
Attachments
This comment was imported from FlySpray: https://bugs.openttd.org/task/6469#comment14751 |
andythenorth wrote:
This comment was imported from FlySpray: https://bugs.openttd.org/task/6469#comment14752 |
Some comments on the patch:
I cannot judge if the SSE2 code is any good, so I believe that on face value :) So just some minor stuff. Sadly, not a PR yet, so a bit hard to comment. |
The patch as posted above has bug(s) in it which have since been fixed in my patchpack. |
Awesome! A separate PR for the likely/unlikely sounds perfect :) Instead of ReallyAdjustBrightness, possible something like: ExecuteAdjustBrightness? AdjustBrightnessInternal? CalculateAdjustedBrightness? Dunno .. something more explaining :) Tnx! |
Any progress on this? Or should we try cherry-picking from your repo? |
Create a new blitter mode: 32bpp-sse2-anim, which is 32bpp-anim + this. 32bpp-sse2-anim is now used by default where 32bpp-anim would have been. Also use this with the 32bpp-sse4-anim blitter. See issue OpenTTD#6469.
Create a new blitter mode: 32bpp-sse2-anim, which is 32bpp-anim + this. 32bpp-sse2-anim is now used by default where 32bpp-anim would have been. Also use this with the 32bpp-sse4-anim blitter. See issue OpenTTD#6469.
Create a new blitter mode: 32bpp-sse2-anim, which is 32bpp-anim + this. 32bpp-sse2-anim is now used by default where 32bpp-anim would have been. Also use this with the 32bpp-sse4-anim blitter. See issue #6469.
Implemented! |
JGR opened the ticket and wrote:
Attachments
Reported version: trunk
Operating system: All
This issue was imported from FlySpray: https://bugs.openttd.org/task/6469
The text was updated successfully, but these errors were encountered: