Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinlock when saving game on server while client is joining #6445

Closed
DorpsGek opened this issue Apr 13, 2016 · 3 comments
Closed

Spinlock when saving game on server while client is joining #6445

DorpsGek opened this issue Apr 13, 2016 · 3 comments
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) stale Stale issues

Comments

@DorpsGek
Copy link
Member

Samu opened the ticket and wrote:

Non-dedicated server gets stuck when selecting a savegame file to load while a client is joining and the server is encoding the save to the client.

This bug is a bit hard to reproduce. It requires 3 things and exact timing:
1 - a savegame file already available to load, preferibly large (4096x4096 map)
2 - a non-dedicated server running, preferibly large (4096x4096 map)
3 - a client joining the server.

Steps:
1+2. Have the savegame file ready for the server:
- launch openttd
- click multiplayer
- click start server
- click new game
- generate a large map (4096x4096 map)
- once it generates, save this game
- have the load game window already open, but before clicking the savegame, a client has to join first

  1. A client joins the server:
    - launch openttd
    - click multiplayer
    - join the server, and then...

... the bug:
- the server will display SAVING GAME when the client joins.
- with the load game window open, time to click the savegame to happen exactly when SAVING GAME message is being displayed.

Result:
- Server gets stuck.
- Client gets a 20 seconds message without an answer from the server, then network-connection lost

Reported version: 1.6.0
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/6445
@DorpsGek
Copy link
Member Author

andythenorth wrote:

'Stuck' = crashes, with crashlog? Or 'stuck' = hangs, spinning?


This comment was imported from FlySpray: https://bugs.openttd.org/task/6445#comment14623

@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 2, 2018

Samu wrote:

hangs


This comment was imported from FlySpray: https://bugs.openttd.org/task/6445#comment14842

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Network labels Apr 7, 2018
@TrueBrain TrueBrain changed the title Non-dedicated server gets stuck Spinlock when saving game on server while client is joining Apr 12, 2018
@TrueBrain TrueBrain added bug Something isn't working and removed bug from FlySpray labels Apr 12, 2018
@andythenorth andythenorth added the stale Stale issues label Jan 5, 2019
@andythenorth
Copy link
Contributor

Thanks for this. At the time of writing this appears to be an isolated bug, and not frequently reported. We do try to address bugs where they occur frequently and/or are easy to reproduce, but this one doesn't look like we can any go further, so I'm closing it. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) stale Stale issues
Projects
None yet
Development

No branches or pull requests

3 participants