Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid sav file versioning? #6442

Closed
DorpsGek opened this issue Apr 8, 2016 · 2 comments
Closed

Invalid sav file versioning? #6442

DorpsGek opened this issue Apr 8, 2016 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Apr 8, 2016

Sylf opened the ticket and wrote:

With older version of openttd, if I tried to open a sav file made with newer version of openttd, it warned me that the savegame was made with newer version. (For example, using OpenTTD 1.4.3 to open a game made with 1.5.X or 1.6.0).

When I try to open a game made with 1.6.0, using version 1.5.3, it doesn't give me that warning, and the "Load" button is not disabled. But when I proceed to load the game, it fails with error "Game Load Failed Broken savegame - Referencing invalid CargoPacket".

I don't know if this is an issue with version 1.5.X not checking the sav file version, or issue with 1.6.0, not saving with properly updated sav file version.

Reported version: 1.6.0
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/6442
@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 8, 2016

frosch wrote:

1.5.x and 1.6.0 have the same savegame version because 1.5.x -> 1.6.0 requires no savegame conversion.

However, the increased number of supported NewGRF industries make 1.5.x fail to load 1.6.0 saves. The "Referencing invalid CargoPacket" message is incorrect and results from a bug in 1.5.x that was fixed in 1.6.0.

I guess we should just bump the savegame version in 1.6.1 for convenience.

This comment was imported from FlySpray: https://bugs.openttd.org/task/6442#comment14149

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Fixed

in r27572

This comment was imported from FlySpray: https://bugs.openttd.org/task/6442

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek