Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'advanced sprite layout' (stations) #6435

Closed
DorpsGek opened this issue Apr 2, 2016 · 5 comments
Closed

'advanced sprite layout' (stations) #6435

DorpsGek opened this issue Apr 2, 2016 · 5 comments
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Apr 2, 2016

mb opened the ticket and wrote:

Using "advanced sprite layout" for stations
-> http://newgrf-specs.tt-wiki.net/wiki/Action0/Stations# Advanced_sprite_layout_with_register_modifiers_.281A.29
, following spriteset produces weird error message "invalid/unknown sprite layout format ...":

   47 84 00 80  8c 00  07 0e 80  0b 04   // trolley front
   <sprite>    <flags> <xyoff>  <reg> <val>

"0x8c"::= 0x04 (offset to recolour sprite) + 0x08 (recolour sprite from action1) + 0x80 (resolve recolour sprite with var10 set)

That error message is generated for all combinations with 0x80.

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/6435
@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 2, 2016

frosch wrote:

What happened to using escape sequences for numbers bigger than bytes?
Anyway, "groundsprite" is a dword.

This comment was imported from FlySpray: https://bugs.openttd.org/task/6435#comment14137

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 2, 2016

mb wrote:

What happened to using escape sequences for numbers bigger than bytes?

I don´t know. What should happen?

Anyway, "groundsprite" is a dword.

Sure. The complete tile is like that:

[code]
45
8d 0f 00 00 00 00 // ground
2d 04 00 80 02 00 00 06 00 10 04 1e 0a // pylon
47 04 00 80 00 00 07 0e 80 // trolley front # # works (normal)
// 47 84 00 80 8c 00 07 0e 80 0b 04 // trolley front # # BUG (recolour)
2f 04 00 80 00 00 00 00 00 10 06 1e // blue
36 04 00 80 00 00 00 0e 80 // trolley back -3px
3b 04 00 80 00 00 1d 00 80 // trolley back 3px
[/code]

This comment was imported from FlySpray: https://bugs.openttd.org/task/6435#comment14138

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 2, 2016

frosch wrote:

Start with "-d grf=1" and you may get a more detailed message.

This comment was imported from FlySpray: https://bugs.openttd.org/task/6435#comment14139

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 2, 2016

mb wrote:

dbg: [grf] [newstats.grf:5323] ReadSpriteLayoutRegisters: SpriteLayout uses unknown flag 0x80

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/6435#comment14140

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 2, 2016

frosch closed the ticket.

Reason for closing: Fixed

in r27534

This comment was imported from FlySpray: https://bugs.openttd.org/task/6435

@DorpsGek DorpsGek closed this as completed Apr 2, 2016
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek