Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding default-generated compiler flags. #6433

Closed
DorpsGek opened this issue Mar 18, 2016 · 1 comment · Fixed by #6715
Closed

Allow overriding default-generated compiler flags. #6433

DorpsGek opened this issue Mar 18, 2016 · 1 comment · Fixed by #6715
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

adf88 opened the ticket and wrote:

The 'configure' script generates some flags for the compiler (CFLAGS, CXXFLGAS etc.). Also users can add their own flags by passing them to the script. However, user flags have lower priority because automatic flags are added behind them. It means that it is not possible to override the auto-generated flags e.g. it is not possible to turn off some '-Wxxx' if 'configure' script decides to use it.

If auto-generated flags were put before user flags this would not be a problem anymore. While users have full control on what flags they pass to the script, they have limited control on what flags will be generated automatically.

Patch attached (-p0).

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6433
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Build system labels Apr 7, 2018
@andythenorth
Copy link
Contributor

Now that we're on github, this would be good to handle via a pull request.

@TrueBrain TrueBrain added patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay and removed enhancement Issue would be a good enhancement; we accept Pull Requests! Build system labels Apr 14, 2018
TrueBrain added a commit to TrueBrain/OpenTTD that referenced this issue Apr 14, 2018
TrueBrain added a commit that referenced this issue Apr 14, 2018
glx22 pushed a commit to glx22/OpenTTD that referenced this issue Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
3 participants