Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-cache vehicle properties in depot #6423

Closed
DorpsGek opened this issue Feb 21, 2016 · 4 comments
Closed

re-cache vehicle properties in depot #6423

DorpsGek opened this issue Feb 21, 2016 · 4 comments
Labels
component: NewGRF This issue is related to NewGRFs enhancement Issue would be a good enhancement; we accept Pull Requests! flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) needs triage This issue needs further investigation before it becomes actionable stale Stale issues

Comments

@DorpsGek
Copy link
Member

George opened the ticket and wrote:

R27507

In xUSSR set I use code like this

switch (FEAT_TRAINS, SELF, e_e_power, date_of_last_service >= date(1920,1,1))
{
0: return get_power_in_cb(1100);
return get_power_in_cb(1306);
}

It is intended, that when a train visits a depot after specified day, it changes the power to the new value (got automatically upgraded).
Unfortunately, the game changes the power not in depot, but several days later. I suppose, it caches the value and updates the cache while the train is outside depot.
It would be nice, if visiting the depot would force properties recache, guaranteeing that a change happens in depot.

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6423
@DorpsGek
Copy link
Member Author

George wrote:

related task
https://bugs.openttd.org/task/6249 - the same for leaving the station


This comment was imported from FlySpray: https://bugs.openttd.org/task/6423#comment14120

@DorpsGek
Copy link
Member Author

peter1138 wrote:

I guess this can cause a desync currently. Is it sane to refresh when leaving depots?


This comment was imported from FlySpray: https://bugs.openttd.org/task/6423#comment14386

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles labels Apr 7, 2018
@TrueBrain
Copy link
Member

That is a pretty big jump, thinking it might cause a desync? (it changes priority of these tickets). Could you please supply more context if you make this claim?

@TrueBrain TrueBrain added needs triage This issue needs further investigation before it becomes actionable enhancement Issue would be a good enhancement; we accept Pull Requests! and removed enhancement from FlySpray labels Apr 13, 2018
@frosch123 frosch123 added component: NewGRF This issue is related to NewGRFs and removed Vehicles labels Apr 14, 2018
@andythenorth andythenorth added the stale Stale issues label Jan 5, 2019
@andythenorth andythenorth removed the stale Stale issues label Jan 24, 2019
@stale
Copy link

stale bot commented Mar 25, 2019

This issue has been automatically marked as stale because it has not had any activity in the last two months.
If you believe the issue is still relevant, please test on the latest nightly and report back.
It will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale bot added the stale Stale issues label Mar 25, 2019
@stale stale bot closed this as completed Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs enhancement Issue would be a good enhancement; we accept Pull Requests! flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) needs triage This issue needs further investigation before it becomes actionable stale Stale issues
Projects
None yet
Development

No branches or pull requests

4 participants