FS#6383 - "Select upgrade" for content tries to download old versions
A number of NewGRF's and other content on the bananas system have poor version numbers and this means players are downloading and using the wrong versions.
- I have the North American Renewal Set 2.5 and 2.51 installed. Yet when I click "select upgrade", OTTD selects version 2.03.
- Industrial Stations renewal 1.0.2 wants to "upgrade" to 0.8.1
- ab8 Aviators Aircraft Set 2.0 and 2.21 want to upgrade to 1.81
- OpenGFX+ Landscape 1.1.2 wants to upgrade to 0.2.3
I'd suggest there are two problems here:
a) Old versions remaining on Bananas. I'd suggest only allowing one version of any given NewGRF/content to be active on bananas at any given time.
b) The version system using by bananas is inadequate. Possible solution - utilise semantic versioning (http://semver.org/) or some other sort of consistent versioning system for upgrades and require that all uploaded content adhere to it. And/or Flag if an uploaded version has a "lower" number than the current version.
For bonus confusion, if I download say the "upgrade" 0.2.3 OpenGFX+ Landscape, in the NewGRF Settings, only 1.1.2 shows. So that part of the game is able to correctly handle the versioning, it's the download client that fails.
This task depends upon