New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Game Script: method to change company rating in town #6381
Comments
andythenorth wrote:
This comment was imported from FlySpray: https://bugs.openttd.org/task/6381#comment14719 |
Would be a good pull request, now we're on github. |
It looks reasonable, but what effect do you expect with the command? The mechanism of updating the rating is still there, and it will change the rating back to however you behave in the town. The deeper issue is thus, who controls future changes in the rating, the script or the game? If the script, would "indefinitely" be a good choice? I would tend to see these forced changes as temporary, much like an advertising campaign. Also, this patch adds a company to having a rating, wouldn't it also need a way to undo this, giving a company a blank sheet in a town? |
I would suggest three additional methods:
|
You seem to be missing "UnlockTownRating", ie revert to the normal situation where the comapny is known, and should take out city blocks if it wants to keep its reputation. For locking, I'd prefer a number of days as parameter of the lock at least, so it's not indefinitely in case of a script crash or so. It's simple enough to loop every X days to re-inforce the lock. |
I intended LockTownRating to take a boolean whether to lock or unlock, but a days counter might be safer, in that case you can just set the lock timer to 0 days to unlock. |
How about being able to pass a special value (-1 = Infinity) into GSTown.LockTownRating to lock the town rating until either the script unlocks the town rating via another GSTown.LockTownRating call, or the script crashes? |
Thanks for this. There's been no activity on this for some time, and as it stands, it doesn't look likely that it will go any further. Since OpenTTD moved to GitHub, we use pull requests rather than patches, as they are a much more productive workflow. I'm planning to close this soon (in 7 days), as we try to keep the issue count low for OpenTTD, it helps us focus on things that are important and fun. If you would like to continue with this patch, the best way would be to move the patch to your own GitHub fork, update it for the current OpenTTD master, and then create a pull request. For more information, please see our CONTRIBUTING.md. We are also happy to discuss directly on the issue, or in #openttd irc, including help to get this into a pull request. Thanks for your contribution! |
This issue has been automatically marked as stale because it has not had any activity in the last two months. |
dp opened the ticket and wrote:
Attachments
Reported version: 1.5.2
Operating system: All
This issue was imported from FlySpray: https://bugs.openttd.org/task/6381
The text was updated successfully, but these errors were encountered: