Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTTD fails to build on OS X El Capitan #6380

Closed
DorpsGek opened this issue Oct 18, 2015 · 2 comments
Closed

OpenTTD fails to build on OS X El Capitan #6380

DorpsGek opened this issue Oct 18, 2015 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

neverpanic opened the ticket and wrote:

OS X 10.11 "El Capitan" contains a couple of changes that break building OpenTTD. Fortunately, they are easy to fix this time around.

There are two problems:

First, in src/music/cocoa_m.cpp, the include guard to AudioComponent.h is used to check whether AudioComponent.h exists. This include guard changed in 10.11 to AudioUnit_AudioComponent_h. The fix is simple, supporting both symbols.

Second, in src/video/cocoa/wnd_quartz.mm, CMGetSystemProfile and CMCloseProfile are no longer supported and have been removed. To achieve the same thing, we can use CGDisplayCopyColorSpace, which is available since 10.5. See https://bugzilla.mozilla.org/show_bug.cgi?id=923945 for a bug fixing the same problem in the same way.

Attachments

Reported version: 1.5.2
Operating system: Mac OS X


This issue was imported from FlySpray: https://bugs.openttd.org/task/6380
@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 7, 2015

veprbl wrote:

This worked for me. Thank you. Maybe detection in cocoa_m can be improved (see attachment).

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6380#comment14102

@DorpsGek
Copy link
Member Author

michi_cc closed the ticket.

Reason for closing: Implemented

In r27675 (in a slightly adapted form).
Reported to work in Sierra, assuming El Capitan works, too.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6380

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant