Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a bug in path handling of tar files #6377

Closed
DorpsGek opened this issue Oct 13, 2015 · 3 comments · Fixed by #11855
Closed

a bug in path handling of tar files #6377

DorpsGek opened this issue Oct 13, 2015 · 3 comments · Fixed by #11855
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) good first issue Good for newcomers

Comments

@DorpsGek
Copy link
Member

telanus opened the ticket and wrote:

The path handling of tar files seems not to be working.

When two of the same Newgrf's are in the same dir IE ogfx-airports.tar and ogfx-airports-v5748-80.tar, OpenTTD only sees ogfx-airports.tar and any game that is started with ogfx-airports-v5748-80.tar will "update" to ogfx-airports.tar. Unpacking the files into their own Directory "solves" this problem but isn't ideal.

Thread where it was "first" discussed, http://www.tt-forums.net/viewtopic.php?p=1150933# p1150933

Reported version: trunk
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/6377
@DorpsGek
Copy link
Member Author

frosch wrote:

When using tars OpenTTD only considers the path within the tars.

This was a requirement of the old 32bpp technique up to 1.2.0. It is now no longer needed, but noone removed it.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6377#comment14073

@DorpsGek
Copy link
Member Author

peter1138 wrote:

What needs to be removed?


This comment was imported from FlySpray: https://bugs.openttd.org/task/6377#comment14383

@DorpsGek
Copy link
Member Author

frosch wrote:

If there are two tar files:
pathto/tar1.tar
pathto/tar2.tar
and both contain a file
pathwithin/foo.grf
OpenTTD will identify the files via the key "pathwithin/foo.grf". I.e. OpenTTD won't be able to distinguish them and picks one at random.

To fix this, OpenTTD should include the tar name into the key.

Anyway, I have seen work-in-progress patches by Albert not that long ago. It's part of his scenario mission.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6377#comment14387

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
@TrueBrain TrueBrain added good first issue Good for newcomers bug Something isn't working and removed bug from FlySpray labels Apr 12, 2018
@frosch123 frosch123 removed the Core label Apr 14, 2018
@andythenorth andythenorth added the stale Stale issues label Jan 5, 2019
@TrueBrain TrueBrain removed the stale Stale issues label Jan 24, 2019
@TrueBrain TrueBrain removed the pinned label Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants