Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orders: 'max reliability' order filter #6360

Closed
DorpsGek opened this issue Aug 9, 2015 · 4 comments
Closed

Orders: 'max reliability' order filter #6360

DorpsGek opened this issue Aug 9, 2015 · 4 comments
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Aug 9, 2015

Simons_Mith opened the ticket and wrote:

I set up orders to make vehicles go to depot and stop when they passed their maximum age.
But what I really wanted to do was to send vehicles to depot when their /maximum reliability
after servicing/ dropped too low.

So in the interests of 'do what you mean'*, instead of

'Jump to order 7 when Remaining lifetime (years) is less than 0'

I would like to use

'Jump to order 7 when Maximum reliability is less than 50'

But maximum reliability/reliability after servicing doesn't exist as an order filter. Could it be
added?

* 'Do what you mean' - in programming, when you want a computer to do x, always try to tell
it directly to do x, rather than telling it to do something else that indirectly causes it to do x.
Helps with debugging and improves code clarity.

Reported version: 1.5.1
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6360
@DorpsGek
Copy link
Member Author

chindit wrote:

I've created a patch.
Tested and functional with road vehicles.
I'm testing it with train and planes but it normally works fine.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6360#comment14046

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 2, 2017

andythenorth wrote:

Patch compiles on r27910.

Appears to work as expected, in my brief testing.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6360#comment14731

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles labels Apr 7, 2018
@andythenorth
Copy link
Contributor

Now that we're on github, this would be better handled as a pull request :)

(Assuming it meets code standards) :)

@andythenorth
Copy link
Contributor

Closing as done, thanks all :)

@andythenorth andythenorth removed the stale Stale issues label Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

3 participants