Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much water on generated maps #6335

Closed
DorpsGek opened this issue Jul 10, 2015 · 8 comments
Closed

Too much water on generated maps #6335

DorpsGek opened this issue Jul 10, 2015 · 8 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

miri opened the ticket and wrote:

I play openTTD on my android tablet. I'm running android v4.4.2 on a non-branded tablet.

There was a recent update to the android port of the software, triggered by an update to the SW here I believe, and since then, whenever I generate a new map, it treats my settings wrt amount of ocean/water ("sea level" setting) as "random" rather than either "custom" (2%) or "very low", which are the only two settings I ever use.

I reported the problem to the people who ported this to android, and they responded that it looks like an upstream bug to them and requested that I report it here.

I tested by turning off all AIs, newGRFs, game scripts, etc., and I still get this error. I can't attach a save file since it happens at the time of game generation. I always have far too much water for my tastes, and far more than I used to have before the update.

Thank you!

Reported version: 1.5.1
Operating system: Linux


This issue was imported from FlySpray: https://bugs.openttd.org/task/6335
@DorpsGek
Copy link
Member Author

planetmaker wrote:

What was your previous version of OpenTTD which still behaved in the way you expect it to behave?


This comment was imported from FlySpray: https://bugs.openttd.org/task/6335#comment13999

@DorpsGek
Copy link
Member Author

canaaerus wrote:

I think I noticed the same problem.
It is especially apparent for small maps with one of the sides at most 256 fields.
Starting with the default settings (TerraGenesis, Flat Terrain, Smooth)
and even setting water related options to a minimum (Very Low Sea level, No Rivers),
as soon as Variety distribution is not None, the amount of water on the map goes crazy. (often far over 50%)

I bisected the issue and found that it occurs since revision
(svn r27005) -Fix (r26999): variety distribution curve map scaling did one conversion to height_t too many


This comment was imported from FlySpray: https://bugs.openttd.org/task/6335#comment14000

@DorpsGek
Copy link
Member Author

miri wrote:

Ingo, it was either 1.4.4.36 or 1.4.4.37, I'm not sure which. It's also possible that 1.4.4.37 was never installed on my device (I have auto-update turned off and the difference in time for the android release of 1.4.4.37 and 1.5.1 was only a couple weeks).

Canaaerus, I prefer long, skinny maps, so I'll often have a 128x2048 or similar. That may be exactly why I'm seeing the error. I also never had variety distribution turned all the way off -- I just set it to "none" and generated a new map and the water amount was much more what I like.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6335#comment14003

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Fixed

in r27330


This comment was imported from FlySpray: https://bugs.openttd.org/task/6335

@DorpsGek
Copy link
Member Author

miri wrote:

Ingo, it was either 1.4.4.36 or 1.4.4.37, I'm not sure which. It's also possible that 1.4.4.37 was never installed on my device (I have auto-update turned off and the difference in time for the android release of 1.4.4.37 and 1.5.1 was only a couple weeks).

Canaaerus, I prefer long, skinny maps, so I'll often have a 128x2048 or similar. That may be exactly why I'm seeing the error. I also never had variety distribution turned all the way off -- I just set it to "none" and generated a new map and the water amount was much more what I like.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6335#comment14004

@DorpsGek
Copy link
Member Author

miri wrote:

Ingo, it was either 1.4.4.36 or 1.4.4.37, I'm not sure which. It's also possible that 1.4.4.37 was never installed on my device (I have auto-update turned off and the difference in time for the android release of 1.4.4.37 and 1.5.1 was only a couple weeks).

Canaaerus, I prefer long, skinny maps, so I'll often have a 128x2048 or similar. That may be exactly why I'm seeing the error. I also never had variety distribution turned all the way off -- I just set it to "none" and generated a new map and the water amount was much more what I like.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6335#comment14005

@DorpsGek
Copy link
Member Author

miri wrote:

Out of curiosity, where do I find those additional comments mentioned above? I can't find any reference to r27330, and the latest nightly on the homepage is listed as r27327.

Thank you!


This comment was imported from FlySpray: https://bugs.openttd.org/task/6335#comment14006

@DorpsGek
Copy link
Member Author

frosch wrote:

The "nightly" is built every "night", thus the name. Since last night you can download r27331.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6335#comment14007

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant