OpenTTD

Tasklist

FS#6335 - Too much water on generated maps

Attached to Project: OpenTTD
Opened by Miri (miri) - Friday, 10 July 2015, 01:26 GMT
Last edited by frosch (frosch) - Saturday, 11 July 2015, 10:46 GMT
Type Bug
Category Core
Status Closed
Assigned To No-one
Operating System Linux
Severity Low
Priority Normal
Reported Version 1.5.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

I play openTTD on my android tablet. I'm running android v4.4.2 on a non-branded tablet.

There was a recent update to the android port of the software, triggered by an update to the SW here I believe, and since then, whenever I generate a new map, it treats my settings wrt amount of ocean/water ("sea level" setting) as "random" rather than either "custom" (2%) or "very low", which are the only two settings I ever use.

I reported the problem to the people who ported this to android, and they responded that it looks like an upstream bug to them and requested that I report it here.

I tested by turning off all AIs, newGRFs, game scripts, etc., and I still get this error. I can't attach a save file since it happens at the time of game generation. I always have far too much water for my tastes, and far more than I used to have before the update.

Thank you!
This task depends upon

Closed by  frosch (frosch)
Saturday, 11 July 2015, 10:46 GMT
Reason for closing:  Fixed
Additional comments about closing:  in r27330
Comment by Ingo von Borstel (planetmaker) - Friday, 10 July 2015, 07:28 GMT
What was your previous version of OpenTTD which still behaved in the way you expect it to behave?
Comment by canaaerus (canaaerus) - Friday, 10 July 2015, 12:54 GMT
I think I noticed the same problem.
It is especially apparent for small maps with one of the sides at most 256 fields.
Starting with the default settings (TerraGenesis, Flat Terrain, Smooth)
and even setting water related options to a minimum (Very Low Sea level, No Rivers),
as soon as Variety distribution is not None, the amount of water on the map goes crazy. (often far over 50%)

I bisected the issue and found that it occurs since revision
(svn r27005) -Fix (r26999): variety distribution curve map scaling did one conversion to height_t too many
Comment by Miri (miri) - Saturday, 11 July 2015, 00:38 GMT
Ingo, it was either 1.4.4.36 or 1.4.4.37, I'm not sure which. It's also possible that 1.4.4.37 was never installed on my device (I have auto-update turned off and the difference in time for the android release of 1.4.4.37 and 1.5.1 was only a couple weeks).

Canaaerus, I prefer long, skinny maps, so I'll often have a 128x2048 or similar. That may be exactly why I'm seeing the error. I also never had variety distribution turned all the way off -- I just set it to "none" and generated a new map and the water amount was much more what I like.

Comment by Miri (miri) - Saturday, 11 July 2015, 15:32 GMT
Ingo, it was either 1.4.4.36 or 1.4.4.37, I'm not sure which. It's also possible that 1.4.4.37 was never installed on my device (I have auto-update turned off and the difference in time for the android release of 1.4.4.37 and 1.5.1 was only a couple weeks).

Canaaerus, I prefer long, skinny maps, so I'll often have a 128x2048 or similar. That may be exactly why I'm seeing the error. I also never had variety distribution turned all the way off -- I just set it to "none" and generated a new map and the water amount was much more what I like.

Comment by Miri (miri) - Saturday, 11 July 2015, 15:34 GMT
Ingo, it was either 1.4.4.36 or 1.4.4.37, I'm not sure which. It's also possible that 1.4.4.37 was never installed on my device (I have auto-update turned off and the difference in time for the android release of 1.4.4.37 and 1.5.1 was only a couple weeks).

Canaaerus, I prefer long, skinny maps, so I'll often have a 128x2048 or similar. That may be exactly why I'm seeing the error. I also never had variety distribution turned all the way off -- I just set it to "none" and generated a new map and the water amount was much more what I like.

Comment by Miri (miri) - Saturday, 11 July 2015, 15:40 GMT
Out of curiosity, where do I find those additional comments mentioned above? I can't find any reference to r27330, and the latest nightly on the homepage is listed as r27327.

Thank you!
Comment by frosch (frosch) - Sunday, 12 July 2015, 10:09 GMT
The "nightly" is built every "night", thus the name. Since last night you can download r27331.

Loading...