Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to preserve existing depot orders when demolishing / rebuilding a depot. #6328

Closed
DorpsGek opened this issue Jun 25, 2015 · 2 comments
Closed
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) stale Stale issues

Comments

@DorpsGek
Copy link
Member

adf88 opened the ticket and wrote:

This patch allows to place depots again after demolishing them, without messing vehicle orders (just like stations).

This specific implementation allows to re-place depots only under the same transport type. Road depots can be re-placed as tram depots and vice-versa, this behaviour is consistent with other stuff e.g. it is no problem to put a road depot on a tram order list.

Vehicles going to a demolish depot will skip the order (just like in case of road stops or docks).

For simplicity, depot windows for demolished depots are not allowed.

Last two patches on the queue are optional. One is a code clean-up. Another is for displaying depot names of demolished depots to give a visual feedback.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6328
@DorpsGek
Copy link
Member Author

adf88 wrote:

Note. I'll be working on some related features when I find some free time. I'm planning to implement:
- don't skip train orders for removed depots
- warn about order lists containing removed depots


This comment was imported from FlySpray: https://bugs.openttd.org/task/6328#comment13991

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
@frosch123 frosch123 removed the Core label Apr 14, 2018
@andythenorth andythenorth added the stale Stale issues label Jan 5, 2019
Eddi-z added a commit to Eddi-z/OpenTTD that referenced this issue Jan 12, 2019
Eddi-z added a commit to Eddi-z/OpenTTD that referenced this issue Jan 12, 2019
@andythenorth andythenorth removed patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay stale Stale issues labels Jan 12, 2019
@andythenorth andythenorth changed the title [patch] Moveable depots Try to preserve existing depot orders when demolishing / rebuilding a depot. Jan 12, 2019
Eddi-z added a commit to Eddi-z/OpenTTD that referenced this issue Feb 5, 2019
Eddi-z added a commit to Eddi-z/OpenTTD that referenced this issue Feb 5, 2019
Eddi-z added a commit to Eddi-z/OpenTTD that referenced this issue Feb 5, 2019
Eddi-z added a commit to Eddi-z/OpenTTD that referenced this issue Feb 5, 2019
J0anJosep added a commit to J0anJosep/OpenTTD that referenced this issue Aug 27, 2023
J0anJosep added a commit to J0anJosep/OpenTTD that referenced this issue Aug 27, 2023
J0anJosep added a commit to J0anJosep/OpenTTD that referenced this issue Aug 28, 2023
J0anJosep added a commit to J0anJosep/OpenTTD that referenced this issue Aug 28, 2023
J0anJosep added a commit to J0anJosep/OpenTTD that referenced this issue Sep 17, 2023
J0anJosep added a commit to J0anJosep/OpenTTD that referenced this issue Oct 1, 2023
J0anJosep added a commit to J0anJosep/OpenTTD that referenced this issue Oct 1, 2023
J0anJosep added a commit to J0anJosep/OpenTTD that referenced this issue Oct 19, 2023
J0anJosep added a commit to J0anJosep/OpenTTD that referenced this issue Oct 20, 2023
J0anJosep added a commit to J0anJosep/OpenTTD that referenced this issue Nov 12, 2023
J0anJosep added a commit to J0anJosep/OpenTTD that referenced this issue Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) stale Stale issues
Projects
None yet
Development

No branches or pull requests

3 participants