Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stations blocking town growth #6320

Closed
DorpsGek opened this issue Jun 15, 2015 · 8 comments
Closed

Stations blocking town growth #6320

DorpsGek opened this issue Jun 15, 2015 · 8 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

MeSaber opened the ticket and wrote:

Since the introduction of dead-ends on main road not being an issue for growth, it somehow changed how growth works when "towns are allowed to build roads". Whereas stations will block the town from keep going to the road behind to build houses.

Also what was changed is that you could block roads from making dead-end/turns with rails which hindered it from going that direction. If you do that now you will get major cycle skips and the town cant continue growth in that direction from center.

http://imgur.com/WfLqtfF
The orange squares indicates a cycle skip where it stops and starts over from center tile to find a new path to build house/road. The city is using grid layout 3x3, so its forced to keep that layout. So this is not the reason to the CS.
(No GRFs were used)

http://imgur.com/kLYpkaY
Another picture of the CS happening with a new town surrounded by stations. The white square indicates an RH (replace house) and has nothing to do with it.

http://imgur.com/R9ywXfV
I have a strong reason to believe this is not working as intended. The fix were suppose to remove CS on dead-ends shorter than a tile if i recall correctly. But this as you can see is not the case.. Sure i built these dead-ends myself but why should that matter. Picture shows a 2x2 grid where it cannot place houses at the dead-ends, so its still trying to build houses there even though patch said it shouldnt consider that dead-end as a possible path for growth. Why does it then still try to grow a house there (or a road, which cant happen because its a 2x2 grid.. This might be the error though)

IMO this is critical error. I dont know how much it affects stuff when "town are allowed to build roads" are Disabled as ive mainly played around with cities on reddit server 1 (no grfs).

As a side note, dead-ends or forced grids can be blocked with Canals. This was tested by Me and dP. A good to know information.

Well thx for my time. I can be found on reddit openttd irc if you need me for tests etc.

//Saber (MeSaber @ irc)

Reported version: 1.5.1
Operating system: Windows

This issue was imported from FlySpray: https://bugs.openttd.org/task/6320
@DorpsGek
Copy link
Member Author

MeSaber wrote:

http://imgur.com/wa84heS

Directing the growth towards down/left using stations. People went haywire after seeing this ^^

This comment was imported from FlySpray: https://bugs.openttd.org/task/6320#comment13971

@DorpsGek
Copy link
Member Author

frosch wrote:

Images from external sources.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/6320#comment13972

@DorpsGek
Copy link
Member Author

dp wrote:

My fault, I forgot about drive through road stations in my patch for #6245 :( Attaching a very simple patch to fix it.

As for last picture, it's a separate issue. Probably not even an issue since it always worked this way and my patch wasn't intended to fix it either. That patch does only a trivial check, it doesn't cover all the tricky cases. It sees empty tile, thinks that town can build road there since it is allowed to do so and follows that dead end. But it doesn't know anything about a grid, so it fails miserably when it comes to actually building a road there. Someday I may do a better patch that will cover the rest of cases but I think it's ok to leave it the way it is for the time being.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/6320#comment13975

@DorpsGek
Copy link
Member Author

frosch wrote:

r27305 adds cases for drive-through-road stops and road-bridges.

Your patch above would also have triggered for terminal road stops.

This comment was imported from FlySpray: https://bugs.openttd.org/task/6320#comment13980

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Fixed

in r27305

This comment was imported from FlySpray: https://bugs.openttd.org/task/6320

@DorpsGek
Copy link
Member Author

dp wrote:

Why would it? GetTownRoadBits returns ROAD_NONE for them:

if (IsRoadDepotTile(tile) || IsStandardRoadStopTile(tile)) return ROAD_NONE;

This comment was imported from FlySpray: https://bugs.openttd.org/task/6320#comment13981

@DorpsGek
Copy link
Member Author

dp wrote:

Actually, I don't think your patch works, you're checking tile instead of target_tile

This comment was imported from FlySpray: https://bugs.openttd.org/task/6320#comment13982

@DorpsGek
Copy link
Member Author

frosch wrote:

Actually, I don't think your patch works, you're checking tile instead of target_tile
Yes, also noticed that. Fixed meanwhile.

Why would it? GetTownRoadBits returns ROAD_NONE for them:
Ah, sorry, I skipped directly to GetAnyRoadBits.

This comment was imported from FlySpray: https://bugs.openttd.org/task/6320#comment13983

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek