Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with infrastructure maintenance and bridges #6317

Closed
DorpsGek opened this issue Jun 13, 2015 · 2 comments
Closed

Issues with infrastructure maintenance and bridges #6317

DorpsGek opened this issue Jun 13, 2015 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

marcole opened the ticket and wrote:

I have found several more or less severe issues regarding infrastructure maintenance and bridges.

  1. infrastructure window is not refreshed (dirtied) properly
    a) when drive-through station is removed from different owner's road
    maintenance window is not updated for station's owner
    b) when building or removing road over other owner's railway
    maintenance window is not updated for railway owner

  2. infrastructure count is not updated properly when upgrading town bridge using tramway
    build tram bridge over town road bridge - tramway pieces are not added
    after tramway removal, tramway pieces go negative
    can be abused repeatedly for "nice profit" ;-)

  3. change of bridge owner from town to company
    build tramway on the town road bridge and remove the town road
    bridge owner is switched to the company with ability to destroy the former town bridge
    overall very small effect on local authority in comparison with destroying the town bridge
    possibly not quite a bug, but not correct imho

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/6317
@DorpsGek
Copy link
Member Author

marcole wrote:

I am appending the suggested patch right away for anyone to check and comment.
Patch is for recent trunk 27298.
Windows are refreshed correctly, tramway pieces are added, towns don't lose bridge ownership.
Thanks

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/6317#comment13968

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Fixed

in r27311 to 27313. Thanks for the patches!

This comment was imported from FlySpray: https://bugs.openttd.org/task/6317

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek