Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateStationSignCoord call after station building/joining #6284

Closed
DorpsGek opened this issue Apr 18, 2015 · 5 comments
Closed

UpdateStationSignCoord call after station building/joining #6284

DorpsGek opened this issue Apr 18, 2015 · 5 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

McZapkie opened the ticket and wrote:

Function UpdateStationSignCoord in station_cmd.cpp is called only during deleting station parts.
I propose to call it also during station building or joining parts to the existing station.
Currently station labels sign remains in original location, such behaviour is often abused (so called station sign fraud)
to achieve payment from large distance between sign, whereas real vehicle travel is one magnitude smaller.

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6284
@DorpsGek
Copy link
Member Author

dp wrote:

Station sign position plays an important role in game mechanics, especially on some servers. Having it move unfavourably can really mess up the whole game sometimes. Also this is the first time I hear of it being considered an abuse, on novapolis and btpro you can place sign wherever you want.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6284#comment13880

@DorpsGek
Copy link
Member Author

ST2 wrote:

Actually I agree with McZapkie. station signs should appear in a place where's a part of the station exists. And that, as told, was considered an illegal station spread, accordingly BTPro rules (confirmed by 2 admins), that work as a complement to Multiplayer OpenTTD rules. Afterall, required some "juggling" to get the final station. Anyway, it's my opinion and stations are fixed when spoted (with admin intervention, most of the cases)
(edit: typo)


This comment was imported from FlySpray: https://bugs.openttd.org/task/6284#comment13883

@DorpsGek
Copy link
Member Author

DorpsGek commented May 2, 2015

McZapkie wrote:

dP, your arguing is not quite valid, because station sign already can be moved, just in case of deletion part of the station.
My proposal is to provide symmetry - move station sign also in case of adding part of the station.
It is fair from two reasons: station sign would be well defined for a given station layout, regardless of building method (dragging left to right, right to left, adding, deleting etc.), secondly it would suppress using station label exploit, see attached image for example.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6284#comment13890

@DorpsGek
Copy link
Member Author

DorpsGek commented May 8, 2015

dp wrote:

What you are talking about is called spreading and has nothing to do with station sign. There is already game settings to prevent distant joins and only moderators can rule out those who works around it.
Besides what kind of logic do you expect the game to follow in this case? There is no way at the time of station construction to know which part of it is going to be used.
And just calling UpdateStationSignCoord as you suggested won't do a thing in case of station expansion because it just clamps sign tile to station bounding box.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6284#comment13902

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Flyspray clean up: addressing potential exploits in MP is not a current OpenTTD goal. I'm not commenting on validity of behaviour or not, but I suspect there are 'many sides' to this. Either way, it's not a thing that will currently be changed, so closing. Thanks for the suggestion :)


This comment was imported from FlySpray: https://bugs.openttd.org/task/6284

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant