Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More sane handling of croassing roads with railroads. #6283

Closed
DorpsGek opened this issue Apr 16, 2015 · 7 comments
Closed

More sane handling of croassing roads with railroads. #6283

DorpsGek opened this issue Apr 16, 2015 · 7 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

adf88 opened the ticket and wrote:

When crossing roads or tram tracks with perpendicular railroads, OpenTTD behaves strange if roads are not a full ROAD_X or ROAD_Y (mostly it throws an error). I'm proposing different behaviour - always complement the road and build a crossing. Attached picture explains everything.

The patch is meant to be applied on top of #6280 and #6281 .

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6283
@DorpsGek
Copy link
Member Author

adf88 wrote:

I made a mistake - the patch is meant to be applied on top of #6281 and #6282.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6283#comment13869

@DorpsGek
Copy link
Member Author

frosch wrote:

Trams cannot reverse on that kind of dead end.
So placing a track piece would break the tram network (of a competitor).


This comment was imported from FlySpray: https://bugs.openttd.org/task/6283#comment13872

@DorpsGek
Copy link
Member Author

adf88 wrote:

Apparently you found a bug then. Breaking someone's end-of-line is not disallowed in other commands (CmdBuildRoad, CmdBuildRoadStop). Should this be "fixed"? I can provide appropriate patches...


This comment was imported from FlySpray: https://bugs.openttd.org/task/6283#comment13873

@DorpsGek
Copy link
Member Author

planetmaker wrote:

If those break the EOL of the tram track, IMHO patches for those bugs would be welcome :)

(I wonder how those changes then can be abused to disallow competitors to build any stops in a town by placing two-tile circular tram tracks everywhere :D)


This comment was imported from FlySpray: https://bugs.openttd.org/task/6283#comment13874

@DorpsGek
Copy link
Member Author

krinn wrote:

don't extend an half tile to a full tile when someone put a railtrack on it (your case # 1)
while openttd can convert railtrack to another type if the road is half, it fail if the road is full if the new railtrack cannot do crossing (or with any tracktype when road is oneway).

i don't think it would be that fine someone putting half road oneway everywhere to block competitor rails.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6283#comment13905

@DorpsGek
Copy link
Member Author

adf88 wrote:

OK. Patches are ready (to be applied over latest trunk - r27284).

disallow-breaking-end-of-tram-line.diff
Changes CmdBuildRoad and CmdBuildRoadStop in a way that breaking end-of-tram-line of someone else is no more allowed ("Owned by ..." is thrown).

complement-crossing-roads.diff
Updated patch that also cares about end-of-line.

"while openttd can convert railtrack to another type if the road is half, it fail if the road is full if the new railtrack cannot do crossing (or with any tracktype when road is oneway)."
If the road is half there cannot be any rail tracks on it so I don't know what are you talking about. Also the patch doesn't affect rail conversion tool in any way. Perhaps if you describe the problem step-by-step...

"i don't think it would be that fine someone putting half road oneway everywhere to block competitor rails."
With or or without the patch there is no difference in this matter.

As for blocking road stops, they can be already blocked by a rail track (crossing). However, these circular tram tracks can block tram tracks of other players. So one must decide what's better, allow to break end-of-line or allow to block. Perhaps blocking is less dangerous because braking an end of line can be done silently, without leaving a trace.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6283#comment13907

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Implemented

in r27308 and r27309


This comment was imported from FlySpray: https://bugs.openttd.org/task/6283

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant