Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduced smoke on the bridge for road vehicles #6278

Closed
DorpsGek opened this issue Apr 8, 2015 · 2 comments
Closed

reduced smoke on the bridge for road vehicles #6278

DorpsGek opened this issue Apr 8, 2015 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Apr 8, 2015

McZapkie opened the ticket and wrote:

Currently, RVs emits large cloud of smoke if speed is limited (for example due to slow bridge), because current max speed is not checked (only order max speed).
It can be simply corrected by adding line:

if (this->type == VEH_ROAD) max_speed = min(max_speed, this->GetCurrentMaxSpeed());

before or after
if (this->type == VEH_ROAD || this->type == VEH_SHIP) max_speed = min(max_speed, this->current_order.GetMaxSpeed() * 2);

Reported version: 1.5.0
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/6278
@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 8, 2015

McZapkie wrote:

forgot to mention, that above fixes apply to Vehicle::ShowVisualEffect() function defined in vehicle.cpp

This comment was imported from FlySpray: https://bugs.openttd.org/task/6278#comment13859

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 9, 2015

planetmaker closed the ticket.

Reason for closing: Fixed

Fixed in r27222. Thanks for the report. It was even more general a problem than you described :)

This comment was imported from FlySpray: https://bugs.openttd.org/task/6278

@DorpsGek DorpsGek closed this as completed Apr 9, 2015
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek