Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicles: lifetime profit #6275

Closed
DorpsGek opened this issue Apr 5, 2015 · 5 comments
Closed

Vehicles: lifetime profit #6275

DorpsGek opened this issue Apr 5, 2015 · 5 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Apr 5, 2015

burty opened the ticket and wrote:

This is a quick patch that enables lifetime profit display on vehicles.

Forum link: http://www.tt-forums.net/viewtopic.php?f=33&t=72844

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6275
@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 6, 2015

Alberth wrote:

And some quick comments on the patch.

For the next time, there is no need to provide a binary, we are quite capable of building our own versions :)

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6275#comment13855

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 6, 2015

burty wrote:

Thank you Alberth for your time in looking at my patch and providing feedback.

I have taken the feedback on board (for future as well) and have addressed all of the comments in this latest patch.

Many Thanks,
Ben

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6275#comment13856

@DorpsGek
Copy link
Member Author

burty wrote:

Attaching latest version.

Change log:
Added new setting for news item advisory to use lifetime instead of last year profit.
Added sort by option on vehicle list windows

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6275#comment14106

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 2, 2017

andythenorth wrote:

Patch fails to apply on r27910

HEAD is now at f1e54b4 (svn r27910) -Update from Eints:
openttd-trunk(master)$ curl https://bugs.openttd.org/task/6275/getfile/10434/Lifetime%20profit%20V4.patch | patch -p0
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 11940 100 11940 0 0 73518 0 --:--:-- --:--:-- --:--:-- 73703
(Stripping trailing CRs from patch.)
patching file src/lang/english.txt
Hunk # 4 succeeded at 3675 (offset 14 lines).
(Stripping trailing CRs from patch.)
patching file src/saveload/afterload.cpp
Hunk # 1 succeeded at 2977 (offset 2 lines).
(Stripping trailing CRs from patch.)
patching file src/saveload/saveload.cpp
Hunk # 1 FAILED at 263.
1 out of 1 hunk FAILED -- saving rejects to file src/saveload/saveload.cpp.rej
(Stripping trailing CRs from patch.)
patching file src/saveload/vehicle_sl.cpp
Hunk # 1 succeeded at 685 (offset 2 lines).
(Stripping trailing CRs from patch.)
patching file src/settings_gui.cpp
Hunk # 1 succeeded at 1561 (offset 2 lines).
(Stripping trailing CRs from patch.)
patching file src/settings_type.h
(Stripping trailing CRs from patch.)
patching file src/table/settings.ini
Hunk # 1 succeeded at 2929 (offset 8 lines).
(Stripping trailing CRs from patch.)
patching file src/vehicle.cpp
Hunk # 1 succeeded at 2693 (offset 48 lines).
(Stripping trailing CRs from patch.)
patching file src/vehicle_base.h
Hunk # 1 succeeded at 238 (offset 58 lines).
Hunk # 2 succeeded at 573 (offset 59 lines).
(Stripping trailing CRs from patch.)
patching file src/vehicle_gui.cpp
Hunk # 5 succeeded at 2097 (offset 5 lines).


This comment was imported from FlySpray: https://bugs.openttd.org/task/6275#comment14730

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles labels Apr 7, 2018
@andythenorth
Copy link
Contributor

Thanks for this. Lifetime profit is not a current goal for core. But JGR patch-pack has implemented this (as far as I know), so it can be used there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

2 participants