OpenTTD

Tasklist

FS#6275 - Vehicles: lifetime profit

Attached to Project: OpenTTD
Opened by Ben (burty) - Sunday, 05 April 2015, 18:07 GMT
Last edited by andythenorth (andythenorth) - Monday, 04 September 2017, 07:01 GMT
Type Feature Request
Category Vehicles
Status With patch
Assigned To No-one
Operating System All
Severity Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

This is a quick patch that enables lifetime profit display on vehicles.

Forum link: http://www.tt-forums.net/viewtopic.php?f=33&t=72844
This task depends upon

Comment by Alberth (Alberth) - Monday, 06 April 2015, 07:11 GMT
And some quick comments on the patch.

For the next time, there is no need to provide a binary, we are quite capable of building our own versions :)
Comment by Ben (burty) - Monday, 06 April 2015, 11:56 GMT
Thank you Alberth for your time in looking at my patch and providing feedback.

I have taken the feedback on board (for future as well) and have addressed all of the comments in this latest patch.

Many Thanks,
Ben
Comment by Ben (burty) - Saturday, 26 December 2015, 15:34 GMT
Attaching latest version.

Change log:
Added new setting for news item advisory to use lifetime instead of last year profit.
Added sort by option on vehicle list windows
Comment by andythenorth (andythenorth) - Saturday, 02 September 2017, 12:42 GMT
Patch fails to apply on r27910

HEAD is now at f1e54b437 (svn r27910) -Update from Eints:
openttd-trunk(master)$ curl https://bugs.openttd.org/task/6275/getfile/10434/Lifetime%20profit%20V4.patch | patch -p0
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 11940 100 11940 0 0 73518 0 --:--:-- --:--:-- --:--:-- 73703
(Stripping trailing CRs from patch.)
patching file src/lang/english.txt
Hunk #4 succeeded at 3675 (offset 14 lines).
(Stripping trailing CRs from patch.)
patching file src/saveload/afterload.cpp
Hunk #1 succeeded at 2977 (offset 2 lines).
(Stripping trailing CRs from patch.)
patching file src/saveload/saveload.cpp
Hunk #1 FAILED at 263.
1 out of 1 hunk FAILED -- saving rejects to file src/saveload/saveload.cpp.rej
(Stripping trailing CRs from patch.)
patching file src/saveload/vehicle_sl.cpp
Hunk #1 succeeded at 685 (offset 2 lines).
(Stripping trailing CRs from patch.)
patching file src/settings_gui.cpp
Hunk #1 succeeded at 1561 (offset 2 lines).
(Stripping trailing CRs from patch.)
patching file src/settings_type.h
(Stripping trailing CRs from patch.)
patching file src/table/settings.ini
Hunk #1 succeeded at 2929 (offset 8 lines).
(Stripping trailing CRs from patch.)
patching file src/vehicle.cpp
Hunk #1 succeeded at 2693 (offset 48 lines).
(Stripping trailing CRs from patch.)
patching file src/vehicle_base.h
Hunk #1 succeeded at 238 (offset 58 lines).
Hunk #2 succeeded at 573 (offset 59 lines).
(Stripping trailing CRs from patch.)
patching file src/vehicle_gui.cpp
Hunk #5 succeeded at 2097 (offset 5 lines).

Loading...