Alberth wrote:

Apparently, the error is that you can have a service interval percentage > 100% without ever explicitly setting it.
See also http://irclogs.qmsk.net/channels/openttd/link/1426512743# 1426512743

This comment was imported from FlySpray: https://bugs.openttd.org/task/6254#comment13822

Johnnei wrote:

Managed to reproduce bug with the following steps on r27256:

1. Company A: Defaults maintenance to 15%
2. Company B: Defaults maintenance to 150 days
3. Company B Creates vehicle 1 (Tested with Kirby Paul Tank train engine)
4. Company A buys-out Company B
5. (!) Vehicle 1 now reports: [Default] maintenance 150 days (Which is different compared to the specified defaults of company A)
6. Vehicle 1 auto-replaced to new model (Tested with Chaney 'Jibulee')
7. Vehicle 1 now has a 150% maintenance interval

Proposed resolution:
Upon merging with a company forcibly set the interval settings if the default of `servint_ispercent` mismatches with the new company. (Resolves visual bug)
Changing `BaseConsist::CopyConsistPropertiesFrom` to also copy the interval settings. (This also affects order_backup!)

Proposed patch diff'ed against r27262

Attachments

• fs6254.patch (2.17 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/6254#comment13887

frosch wrote:

About the change in base_consist.cpp:
Why the ToggleBit? As far as I can tell, vehicle_flags is always zero there, and various flags are copied. So, if should be a if (HasBit) SetBit(); line like all the others.

About the change in economy.cpp:
Your changes make all vehicles keep their previous service interval, by making them all use custom service intervals.
I think it should be the other way around. Preserve the "customness" and assign the new default service interval to all vehicles not using a custom interval.

This comment was imported from FlySpray: https://bugs.openttd.org/task/6254#comment13893

Johnnei wrote:

base_consist.cpp:
The vehicle_flags is already filled with the company defaults at that point. So when I used HasBit/SetBit initially it didn't work as the defaults are mismatching. So the flag should be toggled to align with the source vehicle.

economy.cpp:
I've been considering that as well, but choose this way as you're buying up some others company's mess so you should fix the mess as well.
If you still prefer it the other way around then just say so and I'll try and make a new patch for it.

This comment was imported from FlySpray: https://bugs.openttd.org/task/6254#comment13894

Johnnei wrote:

New patch which implements your suggestion. Custom settings will be stored, default will get overridden to new company defaults.
Patch is diff'ed against r27267

Attachments

• FS6254-r2.patch (2.90 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/6254#comment13895

frosch closed the ticket.

Reason for closing: Fixed

in r27282. Thanks Johnnei

This comment was imported from FlySpray: https://bugs.openttd.org/task/6254