Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong waypoint demolition cost #6251

Closed
DorpsGek opened this issue Mar 10, 2015 · 3 comments
Closed

Wrong waypoint demolition cost #6251

DorpsGek opened this issue Mar 10, 2015 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

adf88 opened the ticket and wrote:

If we are removing a single rail waypoint by the waypoint removal tool (ctrl pressed - remove the track too) it costs us PR_CLEAR_WAYPOINT_RAIL. However, when destroying a single rail waypoint by the demolish tool it costs us PR_CLEAR_STATION_RAIL instead of expected PR_CLEAR_WAYPOINT_RAIL.

I'm attaching a patch. It does two things:
- fixes the bug
- deduplicates some code (rail station removal and rail station demolition)

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6251
@DorpsGek
Copy link
Member Author

adf88 wrote:

See also #6252


This comment was imported from FlySpray: https://bugs.openttd.org/task/6251#comment13817

@DorpsGek
Copy link
Member Author

adf88 wrote:

I should have split the patch. So here it is.
The first is the fix. The second is the deduplication (to be applied on top of the fix).

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6251#comment13835

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Implemented

in r27245 and 27246. Thanks!


This comment was imported from FlySpray: https://bugs.openttd.org/task/6251

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant