Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water: separate owners for water and structures on water #6232

Closed
DorpsGek opened this issue Feb 20, 2015 · 3 comments
Closed

Water: separate owners for water and structures on water #6232

DorpsGek opened this issue Feb 20, 2015 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Samu opened the ticket and wrote:

Bug 1:

  1. When building a ship depot or a dock on a canal with no owner, the canal tile, including canal maintenance, becomes part of the company who built the ship depot or dock.

When demolishing the ship depot or dock afterwards, you can notice that the canal is no longer without owner.

In my opinion, it should not convert the canal ownership to the new owner, but this leads me to another issue:
2) It is currently not allowed to build a ship depot or dock on canals owned by a competitor.

But, for example, the upper/lower parts of a lock and buoys are allowed to be built on canal tiles owned by a competitor. This takes me back to the beggining. When demolishing a buoy or a lock that were built on canals from other owners, including no owner, it restores their previous owners correctly.

Bug 2a - related to bug 1, but these require steps for reproducing:

  1. Build a lock on 3 bare tiles with company 1, then destroy it, but let the canals tiles stay.
  2. With company 2, rebuild the lock and make use of those canals owned by company 1.
    Result: When querying land information on the upper/lower parts of that lock, it comes up with them being a lock owned by company 1, while in truth, what is actually owned by company 1 is the canals, not the lock.

Bug 2b:

  1. Build a canal tile with company 1.
  2. With company 2, build a buoy on the canal tile that company 1 built.
    Result: When querying land information on that tile, it says it is a buoy owned by company 1, but what is actually owned by company 1 is the canal, not the buoy.

Reported version: 1.5.0-beta1
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/6232
@DorpsGek
Copy link
Member Author

frosch wrote:

Currently there is only one owner for a water-based tile.
So, stuff build on canals always must have the same owner.

For locks the lock-ownership is defined by the tile in the middle. For the upper and lower tile the ownership is preserved.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6232#comment13877

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 1, 2017

andythenorth wrote:

Not convinced this matters. Tiles have owners. Or not. There's no concept of 'tile owned by Alice, with property belonging to Bob' .


This comment was imported from FlySpray: https://bugs.openttd.org/task/6232#comment14698

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 1, 2017

andythenorth closed the ticket.

Reason for closing: Won't implement

Not convinced this matters. Tiles have owners. Or not. There's no concept of 'tile owned by Alice, with property belonging to Bob' .

Flyspray clean up, so closing. Thanks for the request :)


This comment was imported from FlySpray: https://bugs.openttd.org/task/6232

@DorpsGek DorpsGek closed this as completed Sep 1, 2017
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant