New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autorenew fails for articulated vehicles with mixed cargo #6207
Comments
Alberth wrote:
This comment was imported from FlySpray: https://bugs.openttd.org/task/6207#comment13712 |
frosch wrote:
This comment was imported from FlySpray: https://bugs.openttd.org/task/6207#comment13714 |
frosch wrote:
This comment was imported from FlySpray: https://bugs.openttd.org/task/6207#comment13715 |
TadeuszD wrote:
This comment was imported from FlySpray: https://bugs.openttd.org/task/6207#comment13716 |
TadeuszD wrote:
This comment was imported from FlySpray: https://bugs.openttd.org/task/6207#comment13774 |
Newgrfs shouldn't include articulated vehicles with mixed cargos, it's not supported. Thanks :) I'm closing this as we try to keep the issue count low for OpenTTD, it helps us focus on things that are important and fun. Feel free to discuss in irc or request re-opening if you disagree. Thanks for contributing! |
I disagree! :) I confirmed that autoreplace does not work for the specific case of mixed mail + pax engines, which also do not offer player cargo refits. That limited case seems reasonable to support? Accepting that that the actual implementation might be TMWFTLB. Or alternately to supporting this, the autoreplace GUI could not offer the articulated vehicle as a valid replacement option? GRF attached. Test situation is
iron-horse-2.8.0-5-g1926053b.zip Relevant LOC seems to be https://github.com/OpenTTD/OpenTTD/blob/master/src/autoreplace_cmd.cpp#L212 |
i think the only way to reasonably solve this would be with template replacement. |
@JGRennison Did you fix this in #11253? |
Yes this should be fixed |
Summary of this topic
Current situation:
Task:
Note:
TadeuszD opened the ticket and wrote:
Attachments
Reported version: 1.4.4
Operating system: All
This issue was imported from FlySpray: https://bugs.openttd.org/task/6207
The text was updated successfully, but these errors were encountered: