OpenTTD

Tasklist

FS#6207 - Silent autorenew failure (was Support for multi-cargo vehicles in autorenew process)

Attached to Project: OpenTTD
Opened by Tadeusz (TadeuszD) - Thursday, 15 January 2015, 15:44 GMT
Last edited by Alberth (Alberth) - Thursday, 15 January 2015, 17:29 GMT
Type Bug
Category Vehicles → Articulated
Status New
Assigned To No-one
Operating System All
Severity Low
Priority Normal
Reported Version 1.4.4
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

The autorenew mechanism doesn't work correctly for articulated train vehicles, which can transport more than one cargo type.

Those vehicles can be defined via NewGRF addons. For example, the EMU contained 2 or more articulated parts, where:
- one part can be rebuilt to passengers/mail.
- rest of parts can transport only passengers,
Example train is properly supported in the Train refit window and the Train information window. All available cargoes are displayed. Player can refit mentioned train for transport only passengers or passengers+mail.

But autorenew mechanism works partially. When the train is refitted for transport only passengers, everything is OK. However, when the train is refitted for transport passengers+mail, autorenew process fails without any warning. The train is going very old and may lead to the collapse of the company.

It would be nice to add full support for multi-cargo vehicles in autorenew process.
   EN57.png (60.9 KiB)
This task depends upon

Comment by Alberth (Alberth) - Thursday, 15 January 2015, 17:28 GMT
Silent autorenew failure sounds more like a bug than a feature request. It can be a bug in the newgrf though.
Can you provide instructions how to reproduce it, and what you result you find wrong?

Comment by frosch (frosch) - Thursday, 15 January 2015, 18:31 GMT
It's implemented like that.
Autoreplace refuses to replace articulated vehicles which carry multiple cargos, because it is non-obvious what replacements should be allowed, and how they should be refitted.
Comment by frosch (frosch) - Thursday, 15 January 2015, 18:50 GMT
Ah, I guess one can make it work for autorenew, by adding a special case that uses clone instead of build+refit.
Autoreplace won't work in any case though.
Comment by Tadeusz (TadeuszD) - Thursday, 15 January 2015, 20:14 GMT
Frosch is right. It's not a bug. It's implemented like that.

To reproduce described 'bug', you can use test version of my NewGRF. You can download it from https://dev.openttdcoop.org/attachments/download/6997/pkp-set-2.0.11.grf
NewGRF NML source is available in project repository:
https://dev.openttdcoop.org/projects/pkpset/repository/changes/src/engines/enxx-common.pnml
https://dev.openttdcoop.org/projects/pkpset/repository/changes/src/engines/en57.pnml

The EMU EN57 (available since 1957) can be refitted to carry passengers and mail.
Comment by Tadeusz (TadeuszD) - Thursday, 12 February 2015, 19:39 GMT
Small update. Polish PKP Set 2.0.11 is now available on BaNaNaS.
You can test mentioned bug using EMUs: EN57 (available since 1957) and EN71 (available since 1976).

Loading...