Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oversized Object Window when using OGFX+ Landscape 1.1.1 #6178

Closed
DorpsGek opened this issue Nov 30, 2014 · 2 comments
Closed

Oversized Object Window when using OGFX+ Landscape 1.1.1 #6178

DorpsGek opened this issue Nov 30, 2014 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

arikover opened the ticket and wrote:

The new 1.1.1 version seems to be responsible for a small (yet annoying) bug: The object placement window is always oversized, not to be resized because the button lies in the unaccessible bottom right corner.

How to reproduce the bug:
-newgrfs : OGFX+ Landscape 1.1.1 alone.
-new game
-open object window

For some weird reason, this doesn't happen with version 1.1.0.

This bug occurs with trunk r27038, r27068, as well as with OTTD 1.4.3.

I thought at first that it was only a bug related to OGFX+ Landscape, but I've been told (Alberth) it looked more like it is caused by OTTD itself.

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/6178
@DorpsGek
Copy link
Member Author

Alberth wrote:

I tracked the actual problem back to the NewGrf, where the antenna was stated to be 96 tiles high.
https://dev.openttdcoop.org/issues/7327

So while the NewGRF was in error here, the question is perhaps how to handle such cases properly. The ObjectSpec::height data member documentation says "The height of this structure, in heightlevels; max MAX_TILE_HEIGHT." where MAX_TILE_HEIGHT = 255.
Given that 96 is already high enough to fill my entire screen height, I don't even want to know the height of the window with max object height.

This comment was imported from FlySpray: https://bugs.openttd.org/task/6178#comment13643

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 2, 2015

Rubidium closed the ticket.

Reason for closing: Bug in NewGRF

There is not much that OpenTTD can do about this. What are valid heights, and what aren't? Especially since we can go way above the 96 heightlevels in this NewGRF.

This comment was imported from FlySpray: https://bugs.openttd.org/task/6178

@DorpsGek DorpsGek closed this as completed Jan 2, 2015
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek