Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the calculation of the station rating. #6165

Closed
DorpsGek opened this issue Nov 8, 2014 · 1 comment
Closed

Improve the calculation of the station rating. #6165

DorpsGek opened this issue Nov 8, 2014 · 1 comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Nov 8, 2014

Jaap opened the ticket and wrote:

This case could be reproduced in any game, but here's our game to demonstrate this issue.
At the bottom of the map, we have a Food Processing Plant which produces 27k tonnes of food which is less than 70% transported. The trains at station "Food Load" should transport this food to the other side of them map.

Each train has an capacity of 288 tonnes of food, so this amount is reserved when the train starts loading.
When 1440 tonnes are a available at the station, 5 trains can be loaded at the same time. The other trains are waiting at 0% until more food comes available.

The rating of the station stays lower than 70%, and it doesn't matter what you do to increase this percentage, it's stays impossible. The only way to increase this percentage is to build an extra station and let a part of the trains loading at this station.

I'll suggest to do the next modification in the file station_cmd.cpp at line 3295.
Replace "uint waiting = ge->cargo.TotalCount();"
to "uint waiting = ge->cargo.TotalCount() - ge->cargo.ReservedCount();".
So only the amount of cargo which can't be loaded into a train will be used for calculating the station rating.

Reported version: 1.4.4
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6165
@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Implemented

in r27256


This comment was imported from FlySpray: https://bugs.openttd.org/task/6165

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant