Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Industry Creation slow #6154

Closed
DorpsGek opened this issue Oct 26, 2014 · 10 comments
Closed

Industry Creation slow #6154

DorpsGek opened this issue Oct 26, 2014 · 10 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Marctraider opened the ticket and wrote:

Latest trunk, standard openttd settings, map size on 4096x4096, industry density on max, no grfs loaded, tropical climate.

I couldnt help but notice on how industry generation has suddenly become? Its literally 20x as slow as previously, it takes more than 5 minutes now where it would normally take 30 seconds max.

Reported version: trunk
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/6154
@DorpsGek
Copy link
Member Author

Marctraider wrote:

Anyway, doesnt really need any additional files as it is quite easily replicated.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6154#comment13581

@DorpsGek
Copy link
Member Author

frosch wrote:

Please attach a savegame, which took long to generate, and was faster with older version (which exactly?)

The savegame will contain all settings, so typing "restart" in the console will replicate generation under the exact same settings.
Also create the savegame with the older version, so it can be loaded in both the old and current version.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6154#comment13582

@DorpsGek
Copy link
Member Author

Marctraider wrote:

Mhh I think I was a bit too fast with my conclusions, I forgot i did not have the default openttd settings, it was taking from My Documents.

Never the less still odd, I'm not aware of any option other than FIRS as a newgrf etc that makes Industry Creation a bit slower, but not even this slow.

It happens with all revisions ive tested so the best I can do is pass along the openttd.cfg i used. really odd as this openttd.cfg is almost completely default.

Perhaps you can load with this openttd.cfg and make a map of 4096x4096 and industry density at high and then with a clean config, also 4096x4096 and industry at high. Notice the huge difference,

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6154#comment13583

@DorpsGek
Copy link
Member Author

planetmaker wrote:

I don't see a difference of that significance between 1.3.0 and current trunk with the supplied cfg. Maybe indeed supply an actual savegame - as that also contains the random number used unlike the cfg. And specify what you mean with 'earlier OpenTTD version'. Mind that you also were asked to provide a savegame which exhibits that issue instead of a cfg to avoid issues with using the exact newgrf(s) (found in different paths and so on) and things like that.

Timing from start to finished map gen:

OpenTTD 1.3.0:
real 1m17.764s
user 1m11.012s
sys 0m2.884s

OpenTTD r27038
real 1m27.800s
user 1m22.464s
sys 0m2.952s


This comment was imported from FlySpray: https://bugs.openttd.org/task/6154#comment13584

@DorpsGek
Copy link
Member Author

Marctraider wrote:

Yep that is definately not what ive encountered now a few times, ill try to pinpoint whats causing it and give an update :)


This comment was imported from FlySpray: https://bugs.openttd.org/task/6154#comment13597

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 4, 2014

Marctraider wrote:

Think i know what the prob is, once you set number of towns very low (1 or perhaps a bit more) the industry creation goes dog slow. Its like the river generator having trouble on some heightmaps and goes into a deep mathematical endeavour and kind of chokes on its stuff.

Could be considered a 'bug' still i guess, might be worth it to solve this somehow.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6154#comment13610

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 4, 2014

Alberth wrote:

You're giving the machine a very difficult task, insanely large map with few towns (so finding the nearest town takes a lot of time), and "multiple_industry_per_town = false", ie VERY limited placement options, and an very large number of industries that must be placed.
Since it also tries a lot of times to place each industry before giving up, yes, it's going to be slow.

Why do you use dense industries in the first place at such a map, especially if you don't actually want many industries (given your number of towns and the town restrictions)?


This comment was imported from FlySpray: https://bugs.openttd.org/task/6154#comment13612

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 5, 2014

Marctraider wrote:

Well, why would you want to create rivers on a heightmap where they can barely exist? Ive encountered a few times where river creation was so slow i just had to end the task in task manager :p

Ask the rivers!

Anyway sorry for reporting this unfortunate discovery, I guess i found myself reporting a bug where non existed!


This comment was imported from FlySpray: https://bugs.openttd.org/task/6154#comment13613

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 5, 2014

Marctraider wrote:

Better safe than sorry :)


This comment was imported from FlySpray: https://bugs.openttd.org/task/6154#comment13614

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Unreproducible


This comment was imported from FlySpray: https://bugs.openttd.org/task/6154

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant