Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openttd crash when toggling full animation. r26752 #6096

Closed
DorpsGek opened this issue Aug 22, 2014 · 7 comments
Closed

Openttd crash when toggling full animation. r26752 #6096

DorpsGek opened this issue Aug 22, 2014 · 7 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Marctraider opened the ticket and wrote:

Happens on latest trunk r26752, also tried on r26694 same story.

Description:

When starting the game without full animation, join network game, turn on full animation results in a crash. I suspect auto switching blitter?

- Happens only in multiplayer I believe?
- Turned off all GRFs on server and client, tried default config too.
- I am unable to replicate this bug on a mac or linux compiled build.

Temporary solution for me was to change blitter to a fixed one, like 8bpp-optimized or 32bpp-anim etc. Since then i cannot reproduce it. Im lost at this point on what it could be.

If you folks need a test server:
mtredditserver5.ddns.net:3979
password: derp
Its free for you to test on, it only seems to happen in multiplayer but perhaps im wrong.

EDIT: reposted the crash dumps, the first 3 where accidentaly from a modified version.

Q'apla!

Attachments

Reported version: trunk
Operating system: Windows

This issue was imported from FlySpray: https://bugs.openttd.org/task/6096
@DorpsGek
Copy link
Member Author

frosch wrote:

Information from crash.dmp:
00000000`0015f0e8 00000001`3fe21ce1 : 00000000`00000000 00000000`00000080 00000000`00000000 00000001`3fc53d2f : openttd!memcpy+0xc5 [f:\dd\vctools\crt_bld\SELF_64_amd64\crt\src\amd64\memcpy.asm @ 197]
00000000`0015f0f0 00000001`3fc8f6b6 : 00000000`24c17730 00000001`40840608 00000000`0b1163fa 00000000`0000026c : openttd!Blitter_32bppAnim::CopyFromBuffer+0xd9 [c:\bamboo-agent-home\xml-data\build-dir\ottd-nightly-w64bit\src\blitter\32bpp_anim.cpp @ 353]
00000000`0015f170 00000001`3fbdf718 : 00000000`000001e0 00000000`00000000 00000000`00000000 000007fe`fdc11203 : openttd!NetworkUndrawChatMessage+0x12a [c:\bamboo-agent-home\xml-data\build-dir\ottd-nightly-w64bit\src\network\network_chat_gui.cpp @ 172]
00000000`0015f1c0 00000001`3fbdf8fb : 00000000`00000280 00000000`00000000 00000000`000001e0 00000000`00000001 : openttd!RedrawScreenRect+0x80 [c:\bamboo-agent-home\xml-data\build-dir\ottd-nightly-w64bit\src\gfx.cpp @ 1271]
00000000`0015f200 00000001`3fc5403e : 00000000`00000000 00000000`0000ffff 00000000`0b1163fa 00000000`0b1163f8 : openttd!DrawDirtyBlocks+0x17f [c:\bamboo-agent-home\xml-data\build-dir\ottd-nightly-w64bit\src\gfx.cpp @ 1363]
00000000`0015f250 00000001`3fea4152 : 00000000`0b116300 00000000`0015f400 00000000`0b1163ea 00000000`0b1163ea : openttd!UpdateWindows+0x15a [c:\bamboo-agent-home\xml-data\build-dir\ottd-nightly-w64bit\src\window.cpp @ 3024]
00000000`0015f280 00000001`3fc10bda : 00000000`00000000 00000000`0015f410 00000000`00000000 00000000`00000000 : openttd!VideoDriver_Win32::MainLoop+0x402 [c:\bamboo-agent-home\xml-data\build-dir\ottd-nightly-w64bit\src\video\win32_v.cpp @ 1312]
00000000`0015f310 00000001`3fea6801 : 00000000`00000000 00000000`0015f640 00000000`00000001 00000000`00000000 : openttd!openttd_main+0xede [c:\bamboo-agent-home\xml-data\build-dir\ottd-nightly-w64bit\src\openttd.cpp @ 865]
00000000`0015f620 00000001`3ff92be8 : 00000000`00000000 00000000`00000000 00000000`00000000 00000000`00000000 : openttd!WinMain+0x141 [c:\bamboo-agent-home\xml-data\build-dir\ottd-nightly-w64bit\src\os\windows\win32.cpp @ 457]

Seems to be related to drawing the chat message overlay, which explains why it only appears to happen in multiplayer.

This comment was imported from FlySpray: https://bugs.openttd.org/task/6096#comment13475

@DorpsGek
Copy link
Member Author

Marctraider wrote:

Mhh very interesting

This comment was imported from FlySpray: https://bugs.openttd.org/task/6096#comment13476

@DorpsGek
Copy link
Member Author

Marctraider wrote:

So would you say that if i started chattin a bit in single player, and toggle on full animation it should crash too?

This comment was imported from FlySpray: https://bugs.openttd.org/task/6096#comment13477

@DorpsGek
Copy link
Member Author

peter1138 wrote:

Can you try this patch?

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/6096#comment13538

@DorpsGek
Copy link
Member Author

Marctraider wrote:

Sure.

This comment was imported from FlySpray: https://bugs.openttd.org/task/6096#comment13539

@DorpsGek
Copy link
Member Author

Marctraider wrote:

Tested, compiled and i can no longer reproduce the crash under said conditions.

This comment was imported from FlySpray: https://bugs.openttd.org/task/6096#comment13540

@DorpsGek
Copy link
Member Author

peter1138 closed the ticket.

Reason for closing: Fixed

In r26919

This comment was imported from FlySpray: https://bugs.openttd.org/task/6096

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek