krinn wrote:

Begin() Next() documentation need a less blur description.
Returns:
the item value of the first item.

Begin() return the first item, but "item value of the first item" is not clear and may tell it return the "value of first item".
(as i suppose someone will need to dig in script_list.cpp to fix the bug, can be fine to alter that while doing it).

This comment was imported from FlySpray: https://bugs.openttd.org/task/6085#comment13447

krinn wrote:

Adding a log filtered with only the GS output.

Attachments

• gslog.txt (9.63 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/6085#comment13448

krinn wrote:

Adding info : all my trys to see the bug with 1.4 fail.
So i'm unlucky at seeing it with 1.4 or it do work correctly with 1.4.0 and fail with trunk r26728

This comment was imported from FlySpray: https://bugs.openttd.org/task/6085#comment13450

Rubidium wrote:

I see no reason why 1.4 would behave differently than trunk (@r26728). It might be fixed in r26736, can you confirm that or does it still happen? The documentation should be clearer since r26734.

This comment was imported from FlySpray: https://bugs.openttd.org/task/6085#comment13454

krinn wrote:

Perfect! 4 times run over the same savegame (that i couldn't use with 1.4.0)

Attachments

• r26737.txt (1.48 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/6085#comment13456

frosch wrote:

Can you please check again with >= r26744. There were still issues.

This comment was imported from FlySpray: https://bugs.openttd.org/task/6085#comment13458

krinn wrote:

i download and build this version -> http://hg.openttd.org/openttd/trunk.hg/rev/8a38e83175d0
and patch my GS with :

print("list after sort="+Utils.ArrayListToString(zlist));
print("begin="+zlist.Begin()+" next="+zlist.Next()+" isEnd="+zlist.IsEnd());
Scheduler.FullPlay(zlist);

function Scheduler::FullPlay(list)
{
print("");
list.Sort(GSList.SORT_BY_VALUE, GSList.SORT_ASCENDING);
print("list value+ascending : "+Utils.ArrayListToString(list));
print("begin="+list.Begin()+" next="+list.Next()+" IsEnd="+list.IsEnd());
list.Sort(GSList.SORT_BY_ITEM, GSList.SORT_ASCENDING);
print("list item+ascending : "+Utils.ArrayListToString(list));
print("begin="+list.Begin()+" next="+list.Next()+" IsEnd="+list.IsEnd());
list.Sort(GSList.SORT_BY_VALUE, GSList.SORT_DESCENDING);
print("list value+descending : "+Utils.ArrayListToString(list));
print("begin="+list.Begin()+" next="+list.Next()+" IsEnd="+list.IsEnd());
list.Sort(GSList.SORT_BY_ITEM, GSList.SORT_DESCENDING);
print("list item+descending : "+Utils.ArrayListToString(list));
print("begin="+list.Begin()+" next="+list.Next()+" IsEnd="+list.IsEnd());
}

And here's the output (nothing wrong for me there).
Note that items are made of vehicleID and their reliability, The only one that should always be in it is vehicleID=61 with reliability=0 because the AI have a bug with it and keep it in depot. The list may changes and catch vehicles with reliability < 50.

Attachments

• newtest.txt (6.39 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/6085#comment13459

frosch closed the ticket.

Reason for closing: Fixed

in r26744

This comment was imported from FlySpray: https://bugs.openttd.org/task/6085