New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orders: it does not jump order by remaining lifetime #6078
Comments
frosch wrote:
This comment was imported from FlySpray: https://bugs.openttd.org/task/6078#comment13435 |
telk5093 wrote:
This comment was imported from FlySpray: https://bugs.openttd.org/task/6078#comment13436 |
Alberth wrote:
This comment was imported from FlySpray: https://bugs.openttd.org/task/6078#comment13518 |
telk5093 wrote:
This comment was imported from FlySpray: https://bugs.openttd.org/task/6078#comment13519 |
jogi wrote:
Attachments
This comment was imported from FlySpray: https://bugs.openttd.org/task/6078#comment13751 |
jogi wrote:
Attachments
This comment was imported from FlySpray: https://bugs.openttd.org/task/6078#comment13765 |
Alberth wrote:
This comment was imported from FlySpray: https://bugs.openttd.org/task/6078#comment13766 |
jogi wrote:
Attachments
This comment was imported from FlySpray: https://bugs.openttd.org/task/6078#comment13768 |
If this patch meets standards, this would be a good pull request (the issue is specific, detailed, and the patch has already had review and revision). Bug or enhancement? Dunno :) Better that it were fixed though, less user confusion. |
Thanks for this. There's been no activity on this for some time, and as it stands, it doesn't look likely that it will go any further. Since OpenTTD moved to GitHub, we use pull requests rather than patches, as they are a much more productive workflow. I'm planning to close this soon (in 7 days), as we try to keep the issue count low for OpenTTD, it helps us focus on things that are important and fun. If you would like to continue with this patch, the best way would be to move the patch to your own GitHub fork, update it for the current OpenTTD master, and then create a pull request. For more information, please see our CONTRIBUTING.md. We are also happy to discuss directly on the issue, or in #openttd irc, including help to get this into a pull request. Thanks for your contribution! |
One last chance before I close this one: Final patch from jogi applies and compiles cleanly: https://bugs.openttd.org/task/6078/getfile/10126/FS6078v3.patch I won't test it, conditional order stuff breaks my brain. |
telk5093 opened the ticket and wrote:
Reported version: 1.4.1
Operating system: All
This issue was imported from FlySpray: https://bugs.openttd.org/task/6078
The text was updated successfully, but these errors were encountered: